Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-02-28 Thread via GitHub
arturobernalg commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2691643865 > @arturobernalg Do you think you would have time to do the following? > > 1. Add two boundary generators, one that always returns the same boundary and one t

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975116073 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -183,35 +184,54 @@ public void processChallenge(

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975126794 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

[jira] [Updated] (HTTPCLIENT-2360) rfc6266 support in MIME multipart

2025-02-28 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated HTTPCLIENT-2360: -- Fix Version/s: 5.5-alpha2 (was: Stuck) > rfc6266 support in

[jira] [Resolved] (HTTPCLIENT-2360) rfc6266 support in MIME multipart

2025-02-28 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved HTTPCLIENT-2360. --- Resolution: Fixed > rfc6266 support in MIME multipart >

[jira] [Commented] (HTTPCLIENT-2360) rfc6266 support in MIME multipart

2025-02-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931434#comment-17931434 ] ASF subversion and git services commented on HTTPCLIENT-2360:

Re: [PR] Enhance filename encoding in multipart/form-data (HTTPCLIENT-2360) [httpcomponents-client]

2025-02-28 Thread via GitHub
arturobernalg commented on PR #618: URL: https://github.com/apache/httpcomponents-client/pull/618#issuecomment-2690478508 > @arturobernalg While you are at it, do you think you could remove the code that randomly generates boundary values with a fixed boundary and update the javadocs to in

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975474691 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975473201 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975466548 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
stoty commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975479421 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
stoty commented on PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#issuecomment-2690738601 I have split the mutual auth config option to request and require. Having both takes no effort on our part, but allows for set and pray mutual authentication (though I doubt

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975495429 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975468330 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
stoty commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975442398 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
stoty commented on PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#issuecomment-2690773249 I opened https://bugs.squid-cache.org/show_bug.cgi?id=5485 for the Squid issues. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-02-28 Thread via GitHub
ok2c commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2691240479 @arturobernalg Do you think you would have time to do the following? 1. Add two boundary generators, one that always returns the same boundary and one that generates a ran

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
stoty commented on PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#issuecomment-2690151378 I have added a new config option for non-standard servers, and rewritten the established checks. Please take another look @michael-o . -- This is an automated message

Re: [PR] Enhance filename encoding in multipart/form-data (HTTPCLIENT-2360) [httpcomponents-client]

2025-02-28 Thread via GitHub
arturobernalg merged PR #618: URL: https://github.com/apache/httpcomponents-client/pull/618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[jira] [Assigned] (HTTPCLIENT-2360) rfc6266 support in MIME multipart

2025-02-28 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal reassigned HTTPCLIENT-2360: - Assignee: Arturo Bernal > rfc6266 support in MIME multipart > -

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975399408 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] Fixed "boundary-blah" as a default [httpcomponents-client]

2025-02-28 Thread via GitHub
ok2c commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2690641847 @arturobernalg Please, please do not take everything I say literally or even seriously. By boundary_blah I did not mean 'boundary_blah', but something that is unique enough and

[PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [httpcomponents-client]

2025-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #620: URL: https://github.com/apache/httpcomponents-client/pull/620 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.jun

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975197028 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/SpnegoScheme.java: ## @@ -0,0 +1,113 @@ +/* + * ===

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975196166 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

[PR] Fixed "boundary-blah" as a default [httpcomponents-client]

2025-02-28 Thread via GitHub
arturobernalg opened a new pull request, #619: URL: https://github.com/apache/httpcomponents-client/pull/619 Simplify `MultipartEntityBuilder` by replacing random boundary with fixed "boundary-blah" default. Update Javadoc to note users should set custom boundaries if needed, and tweak test

Re: [PR] Enhance filename encoding in multipart/form-data (HTTPCLIENT-2360) [httpcomponents-client]

2025-02-28 Thread via GitHub
ok2c commented on PR #618: URL: https://github.com/apache/httpcomponents-client/pull/618#issuecomment-2690416896 @arturobernalg While you are at it, do you think you could remove the code that randomly generates boundary values with a fixed boundary and update the javadocs to instruct the

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
stoty commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975386169 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#issuecomment-2690801020 > I opened https://bugs.squid-cache.org/show_bug.cgi?id=5485 for the Squid issues. Thanks, very good. mod_auth_gssapi is the gold standard for me written by very kno

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-02-28 Thread via GitHub
michael-o commented on code in PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#discussion_r1975516352 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/gss/GssSchemeBase.java: ## @@ -0,0 +1,366 @@ +/* + * ==