Re: [PR] Add NextNonceInterceptor for nextnonce extraction from Authentication-Info headers [httpcomponents-client]

2024-11-03 Thread via GitHub
arturobernalg commented on code in PR #596: URL: https://github.com/apache/httpcomponents-client/pull/596#discussion_r1826947228 ## httpclient5/src/main/java/org/apache/hc/client5/http/protocol/NextNonceInterceptor.java: ## @@ -0,0 +1,146 @@ +/* + *

Re: [PR] Add NextNonceInterceptor for nextnonce extraction from Authentication-Info headers [httpcomponents-client]

2024-11-03 Thread via GitHub
arturobernalg merged PR #596: URL: https://github.com/apache/httpcomponents-client/pull/596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [PR] Enhance DigestScheme for RFC 7616 Compliance and Expanded Hash Algorithm Support [httpcomponents-client]

2024-11-03 Thread via GitHub
ok2c commented on code in PR #597: URL: https://github.com/apache/httpcomponents-client/pull/597#discussion_r1826989375 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/DigestScheme.java: ## @@ -590,4 +618,27 @@ private boolean containsInvalidABNFChars(final St

Re: [PR] Add NextNonceInterceptor for nextnonce extraction from Authentication-Info headers [httpcomponents-client]

2024-11-03 Thread via GitHub
ok2c commented on code in PR #596: URL: https://github.com/apache/httpcomponents-client/pull/596#discussion_r1826925768 ## httpclient5/src/main/java/org/apache/hc/client5/http/protocol/NextNonceInterceptor.java: ## @@ -0,0 +1,146 @@ +/* + * =

Re: [PR] Enhance DigestScheme for RFC 7616 Compliance and Expanded Hash Algorithm Support [httpcomponents-client]

2024-11-03 Thread via GitHub
arturobernalg commented on code in PR #597: URL: https://github.com/apache/httpcomponents-client/pull/597#discussion_r1826919713 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/DigestScheme.java: ## @@ -590,4 +618,27 @@ private boolean containsInvalidABNFChars

Re: [PR] Enhance DigestScheme for RFC 7616 Compliance and Expanded Hash Algorithm Support [httpcomponents-client]

2024-11-03 Thread via GitHub
arturobernalg commented on PR #597: URL: https://github.com/apache/httpcomponents-client/pull/597#issuecomment-2453326205 > @arturobernalg Looks good to me. > > Please do consider investing some effort into creating compatibility integration tests with Apache HTTPD or Ngnix in `httpc