Re: [PR] Add TE header validation for HTTP/2 and HTTP/1.1 requests [httpcomponents-core]

2024-10-17 Thread via GitHub
ok2c commented on PR #498: URL: https://github.com/apache/httpcomponents-core/pull/498#issuecomment-2418919678 @arturobernalg It is not our job to police the users, if they manually add headers to requests. We need to ensure strict protocol conformance of headers that HttpCore protocol int

Re: [PR] Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). [httpcomponents-client]

2024-10-17 Thread via GitHub
ok2c commented on PR #590: URL: https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2418941091 > @ok2c, I'm not entirely sure I understand. From what I can see, `HttpIntegrationTests$**Http1**>AbstractHttpAsyncFundamentalsTest.testConcurrentPostRequests:152` appears to be

Re: [PR] Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). [httpcomponents-client]

2024-10-17 Thread via GitHub
ok2c commented on PR #590: URL: https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2419251693 @yhzdys I still cannot figure out why tests fail on MacOS but I found a work-around that works on all platforms https://github.com/ok2c/httpcomponents-client/commit/400b71a00e3d

Re: [PR] Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). [httpcomponents-client]

2024-10-17 Thread via GitHub
yhzdys commented on PR #590: URL: https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2419260721 @ok2c no objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). [httpcomponents-client]

2024-10-17 Thread via GitHub
ok2c closed pull request #590: Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). URL: https://github.com/apache/httpcomponents-client/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). [httpcomponents-client]

2024-10-17 Thread via GitHub
ok2c commented on PR #590: URL: https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2419286628 Superseded by b45e9818cc56d38fce5714ba0c3d566ab96c53c5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use