ok2c commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416116682
@yhzdys No, not really. I can trigger GitHub Actions manually. Please bear
with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
yhzdys commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416119632
@ok2c Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
arturobernalg commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416135126
@ok2c I ran the tests locally on macOS, and some of them are indeed failing
with the current fix.
`ProductName:macOS
ProductVersion:
ok2c commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416099588
@yhzdys Bizarre. Tests pass for me locally on Win11 and Ubuntu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
yhzdys closed pull request #590: Bug fix: Correct the issue with connection
state detection in DefaultManagedAsyncClientConnection#isOpen().
URL: https://github.com/apache/httpcomponents-client/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
ok2c commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416074000
@yhzdys The logic of your fix look correct but now with this change some
integration tests fail. Curiously enough tests pass on Ubuntu and fail on
MacOS. I need to see if I can
yhzdys commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416080038
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
ok2c commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416145966
@yhzdys Good. The tests that fail actually use HTTP/1.1 transport, not
HTTP/2, for which the fix was intended. There is something about HTTP/1.1
connection closure that causes i
ok2c commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2415933212
@yhzdys That is much better. I still want to see if this is the right place
to apply the fix, so please bear with me.
--
This is an automated message from the Apache Git Servi
yhzdys commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2416112816
@ok2c Do I need to resubmit the PR to trigger the integration tests again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
arturobernalg commented on PR #590:
URL:
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2417828518
> Thank you @arturobernalg. @yhzdys The tests that fail actually use
HTTP/1.1 transport, not HTTP/2, for which the fix was intended. There is
something about HTTP/1.1 c
arturobernalg opened a new pull request, #498:
URL: https://github.com/apache/httpcomponents-core/pull/498
This PR introduces two interceptors, H2RequestTE and RequestTE, to ensure
the correct validation of the TE header in both HTTP/2 and HTTP/1.1 requests:
- H2RequestTE: Ensures tha
12 matches
Mail list logo
