[jira] [Commented] (HTTPCLIENT-2346) Javadoc wrong on AsyncHttpRequestRetryExec

2024-10-15 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889496#comment-17889496 ] Oleg Kalnichevski commented on HTTPCLIENT-2346: --- [~patrickjamesbarry]

Re: [PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
massdosage commented on code in PR #589: URL: https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801578332 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java: ## @@ -0,0 +1,156 @@ +/*

Re: [PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
ok2c commented on code in PR #589: URL: https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801130025 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java: ## @@ -0,0 +1,156 @@ +/* + * ==

Re: [PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
ok2c commented on code in PR #589: URL: https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801194855 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java: ## @@ -0,0 +1,156 @@ +/* + * ==

Re: [PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
massdosage commented on code in PR #589: URL: https://github.com/apache/httpcomponents-client/pull/589#discussion_r1800751636 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,119 @@ +/* + *

OPTIONS * over secure HTTP/2 connections with Apache HTTPD. Help needed.

2024-10-15 Thread Oleg Kalnichevski
Folks Any idea why HTTPD Apache/2.4.62 (Unix) OpenSSL/3.0.14 rejects OPTIONS * over secure HTTP/2 connections as invalid with this error message? ``` Request :scheme 'https' and path '*' do not allow creating an absolute URL. Failing request with 400. ``` Such requests still work with HTTP/1.1 c

Re: [PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
massdosage commented on code in PR #589: URL: https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801162862 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java: ## @@ -0,0 +1,156 @@ +/*

[PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
ok2c opened a new pull request, #589: URL: https://github.com/apache/httpcomponents-client/pull/589 Apache HTTPD / Squid compatibility tests have been migrated to TestContainers. This also ensures that more complex authentication scenarios that are difficult to create with our own i

Re: [PR] Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). [httpcomponents-client]

2024-10-15 Thread via GitHub
yhzdys commented on PR #590: URL: https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2415848430 Here is the error log file (with some information removed). [error.log](https://github.com/user-attachments/files/17390450/error.log) -- This is an automated message f

[PR] Bug fix: Correct the issue with connection state detection in DefaultManagedAsyncClientConnection#isOpen(). [httpcomponents-client]

2024-10-15 Thread via GitHub
yhzdys opened a new pull request, #590: URL: https://github.com/apache/httpcomponents-client/pull/590 Invoke method ClientH2IOEventHandler#isOpen() to ensure that the streamMultiplexer is open, because receiving the GOAWAY frame only updates the ClientH2StreamMultiplexer's connState. --

Re: [PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
ok2c commented on PR #589: URL: https://github.com/apache/httpcomponents-client/pull/589#issuecomment-2414924711 > @ok2c The changes look reasonable to me, even though I don't have prior experience with `TestContainers`. @arturobernalg Honestly, nether do it. It is a learning process

Re: [PR] Testcontainers [httpcomponents-client]

2024-10-15 Thread via GitHub
ok2c merged PR #589: URL: https://github.com/apache/httpcomponents-client/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap