Missing documentation in release notes or regression from Core 5.3-alpha2 to 5.3-beta1

2024-09-22 Thread Gary D. Gregory
Hi All, After updating an app from HC Core 5.2.5 to 5.3, my custom version of https://github.com/apache/httpcomponents-core/blob/master/httpcore5-h2/src/test/java/org/apache/hc/core5/http2/examples/H2FileServerExample.java started failing tests because it is replying with a HTTP status 421 inst

[PR] HTTPCLIENT-2159: Mitigating Issues with Charset Handling During Redirects [httpcomponents-core]

2024-09-22 Thread via GitHub
arturobernalg opened a new pull request, #483: URL: https://github.com/apache/httpcomponents-core/pull/483 This PR is an attempt to mitigate the issues highlighted in [HTTPCLIENT-2159,](https://issues.apache.org/jira/browse/HTTPCLIENT-2159). The root problem stems from how we are incorrectl

Re: Missing documentation in release notes or regression from Core 5.3-alpha2 to 5.3-beta1

2024-09-22 Thread Oleg Kalnichevski
On Sun, 2024-09-22 at 19:20 +, Gary D. Gregory wrote: > Hi All, > > After updating an app from HC Core 5.2.5 to 5.3, my custom version of > > https://github.com/apache/httpcomponents-core/blob/master/httpcore5-h2/src/test/java/org/apache/hc/core5/http2/examples/H2FileServerExample.java > > s

[jira] [Commented] (HTTPCLIENT-2159) Invalid handling of charset content type parameter

2024-09-22 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883624#comment-17883624 ] Arturo Bernal commented on HTTPCLIENT-2159: --- Hi [~michael-o]  [~reschke] ,

Re: [PR] HTTPCLIENT-2337: Sanitize X500Principal Logging in SSLConnectionSocketFactory [httpcomponents-client]

2024-09-22 Thread via GitHub
ok2c commented on code in PR #581: URL: https://github.com/apache/httpcomponents-client/pull/581#discussion_r1770279206 ## httpclient5/src/main/java/org/apache/hc/client5/http/ssl/AbstractClientTlsStrategy.java: ## @@ -271,7 +272,7 @@ void verifySession( fi

[jira] [Updated] (HTTPCLIENT-2343) Regression in setting USER_TOKEN context attribute in PoolingHttpClientConnectionManager

2024-09-22 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-2343: -- Fix Version/s: 5.4.1 Affects Version/s: 5.4

Re: [VOTE][LAZY] Release HttpComponents CheckStyle 3 based on RC1

2024-09-22 Thread Arturo Bernal
+1 Arturo On Fri, Sep 20, 2024 at 3:46 PM Oleg Kalnichevski wrote: > Please lazy vote on releasing HttpComponents CheckStyle 3 based on RC1. > > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least one > binding +

Re: [PR] HTTPCLIENT-2337: Sanitize X500Principal Logging in ClientTlsStrategy classes [httpcomponents-client]

2024-09-22 Thread via GitHub
garydgregory commented on PR #581: URL: https://github.com/apache/httpcomponents-client/pull/581#issuecomment-2366812264 Unrelated random failure: ``` Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.046 s <<< FAILURE! - in org.apache.hc.client5.testing.sync.

Re: [VOTE][LAZY] Release HttpComponents CheckStyle 3 based on RC1

2024-09-22 Thread Oleg Kalnichevski
+1 Oleg On Fri, 2024-09-20 at 15:46 +0200, Oleg Kalnichevski wrote: > Please lazy vote on releasing HttpComponents CheckStyle 3 based on > RC1. > > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at least > one binding

Re: [PR] HTTPCLIENT-2337: Sanitize X500Principal Logging in ClientTlsStrategy classes [httpcomponents-client]

2024-09-22 Thread via GitHub
garydgregory commented on code in PR #581: URL: https://github.com/apache/httpcomponents-client/pull/581#discussion_r1770569057 ## httpclient5/src/main/java/org/apache/hc/client5/http/ssl/AbstractClientTlsStrategy.java: ## @@ -322,4 +323,33 @@ void verifySession( }

Re: [PR] HTTPCLIENT-2337: Sanitize X500Principal Logging in ClientTlsStrategy classes [httpcomponents-client]

2024-09-22 Thread via GitHub
garydgregory merged PR #581: URL: https://github.com/apache/httpcomponents-client/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

[jira] [Commented] (HTTPCLIENT-2337) Potentially unsafe logging of X500Principal in SSLConnectionSocketFactory

2024-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883611#comment-17883611 ] ASF subversion and git services commented on HTTPCLIENT-2337:

[jira] [Resolved] (HTTPCLIENT-2337) Potentially unsafe logging of X500Principal in SSLConnectionSocketFactory

2024-09-22 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved HTTPCLIENT-2337. - Fix Version/s: 5.4.1 (was: Stuck) Resolution: F