[jira] [Commented] (HTTPCLIENT-2343) Regression in setting USER_TOKEN context attribute in PoolingHttpClientConnectionManager

2024-09-21 Thread Simon F (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883482#comment-17883482 ] Simon F commented on HTTPCLIENT-2343: - No, I even prefer using the setter as it

[jira] [Commented] (HTTPCLIENT-2343) Regression in setting USER_TOKEN context attribute in PoolingHttpClientConnectionManager

2024-09-21 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883475#comment-17883475 ] Arturo Bernal commented on HTTPCLIENT-2343: --- HI [~bratkartoffel]  What pr

Re: [PR] HTTPCLIENT-2337: Sanitize X500Principal Logging in SSLConnectionSocketFactory [httpcomponents-client]

2024-09-21 Thread via GitHub
ok2c commented on PR #581: URL: https://github.com/apache/httpcomponents-client/pull/581#issuecomment-2365047236 @arturobernalg `SSLConnectionSocketFactory` has been deprecated in favor of `DefaultClientTlsStrategy`. I really think your time and efforts could be better spent elsewhere but

[jira] [Commented] (HTTPCLIENT-1843) Create module httpclient5-compress to use Apache Commons Compress

2024-09-21 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883459#comment-17883459 ] Oleg Kalnichevski commented on HTTPCLIENT-1843: --- [~jkmlee] `commons-co

[jira] [Commented] (HTTPCLIENT-1843) Create module httpclient5-compress to use Apache Commons Compress

2024-09-21 Thread Michael Lee (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883458#comment-17883458 ] Michael Lee commented on HTTPCLIENT-1843: - Hi [~abernal] and other developer

Re: [PR] HTTPCLIENT-2337: Sanitize X500Principal Logging in SSLConnectionSocketFactory [httpcomponents-client]

2024-09-21 Thread via GitHub
arturobernalg commented on PR #581: URL: https://github.com/apache/httpcomponents-client/pull/581#issuecomment-2365211745 > @arturobernalg `SSLConnectionSocketFactory` has been deprecated in favor of `DefaultClientTlsStrategy`. I really think your time and efforts could be better spent els

[jira] [Commented] (HTTPCLIENT-1843) Create module httpclient5-compress to use Apache Commons Compress

2024-09-21 Thread Michael Lee (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883464#comment-17883464 ] Michael Lee commented on HTTPCLIENT-1843: - [~olegk]  - good to know, thanks!

Re: [PR] [HTTPCLIENT-1843] - Delegate compression handling to Apache Commons Compress [httpcomponents-client]

2024-09-21 Thread via GitHub
arturobernalg commented on PR #580: URL: https://github.com/apache/httpcomponents-client/pull/580#issuecomment-2365037894 > Thank you for your update. > > * I have comments embedded throughout. > > * There is some lazy-initialization code here and there, this should be