garydgregory commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-client/pull/581#discussion_r1769461453
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java:
##
@@ -456,4 +461,33 @@ void verifySession(
}
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon F updated HTTPCLIENT-2343:
Description:
Setting the USER_TOKEN context attribute changed between the 5.3.1 and 5.4
relea
Simon F created HTTPCLIENT-2343:
---
Summary: Regression in setting USER_TOKEN context attribute in
PoolingHttpClientConnectionManager
Key: HTTPCLIENT-2343
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2343
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768616169
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/CompressorFactory.java:
##
@@ -0,0 +1,294 @@
+/*
+ * ==
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768632771
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/CompressorFactory.java:
##
@@ -0,0 +1,294 @@
+/*
+ * ==
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768634734
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ===
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768640485
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ===
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768637298
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ===
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768647926
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ===
arturobernalg commented on PR #581:
URL:
https://github.com/apache/httpcomponents-client/pull/581#issuecomment-2363774177
please @garydgregory do another pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768648365
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ===
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768652643
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/LazyDecompressInputStream.java:
##
@@ -0,0 +1,209 @@
+/*
+ * ==
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768651788
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DeflateInputStream.java:
##
@@ -38,7 +38,9 @@
/**
* Deflates an input stream. This c
garydgregory commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-client/pull/581#discussion_r1768575963
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java:
##
@@ -456,4 +461,33 @@ void verifySession(
}
garydgregory commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-client/pull/581#discussion_r1768577181
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java:
##
@@ -456,4 +461,33 @@ void verifySession(
}
dependabot[bot] opened a new pull request, #582:
URL: https://github.com/apache/httpcomponents-client/pull/582
Bumps [org.slf4j:slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to
2.0.0.
Commits
https://github.com/qos-ch/slf4j/commit/0614d467d7bca81724f45e228f4f871161222
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768580758
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/CompressingEntity.java:
##
@@ -0,0 +1,135 @@
+/*
+ * ==
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768582843
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/CompressingEntity.java:
##
@@ -0,0 +1,135 @@
+/*
+ * ==
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883258#comment-17883258
]
Oleg Kalnichevski commented on HTTPCLIENT-2342:
---
Just ran the latest H
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883250#comment-17883250
]
Cedric Tabin commented on HTTPCLIENT-2342:
--
Hello [~abernal],
Thanks for j
ok2c commented on PR #581:
URL:
https://github.com/apache/httpcomponents-client/pull/581#issuecomment-2363601254
@arturobernalg I think we have kind of decided to not do it, but if no one
objects I see no reason to not merge this change-set
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883224#comment-17883224
]
Gary D. Gregory commented on HTTPCLIENT-2342:
-
Hello [~ctabin]
Does th
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883229#comment-17883229
]
Gary D. Gregory commented on HTTPCLIENT-2342:
-
Hi [~ctabin]
I think th
arturobernalg opened a new pull request, #581:
URL: https://github.com/apache/httpcomponents-client/pull/581
This PR addresses
[HTTPCLIENT-2337](https://issues.apache.org/jira/browse/HTTPCLIENT-2337), which
involves potentially unsafe logging of `X500Principal` in
`SSLConnectionSocketFacto
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883231#comment-17883231
]
Arturo Bernal commented on HTTPCLIENT-2342:
---
Hi [~ctabin]
I ran a test w
dependabot[bot] opened a new pull request, #482:
URL: https://github.com/apache/httpcomponents-core/pull/482
Bumps [org.slf4j:slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to
2.0.0.
Commits
https://github.com/qos-ch/slf4j/commit/0614d467d7bca81724f45e228f4f871161222b5
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768616169
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/CompressorFactory.java:
##
@@ -0,0 +1,294 @@
+/*
+ * ==
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768616169
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/CompressorFactory.java:
##
@@ -0,0 +1,294 @@
+/*
+ * ==
arturobernalg commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-client/pull/581#discussion_r1768699939
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java:
##
@@ -403,9 +404,15 @@ void verifySession(
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883346#comment-17883346
]
Cedric Tabin commented on HTTPCLIENT-2342:
--
Hello,
So now we are correctly
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883348#comment-17883348
]
Oleg Kalnichevski commented on HTTPCLIENT-2342:
---
[~ctabin] Please repo
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883346#comment-17883346
]
Cedric Tabin edited comment on HTTPCLIENT-2342 at 9/20/24 4:44 PM:
---
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883348#comment-17883348
]
Oleg Kalnichevski edited comment on HTTPCLIENT-2342 at 9/20/24 4:48 PM:
--
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883350#comment-17883350
]
Cedric Tabin commented on HTTPCLIENT-2342:
--
Yep, it seems something related
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cedric Tabin closed HTTPCLIENT-2342.
Resolution: Not A Bug
> Regression: Content-Type header not returned anymore
> ---
arturobernalg commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1769040048
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ==
arturobernalg commented on PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#issuecomment-2364570970
HI @garydgregory
Please do another pass.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1769261744
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/extension/sync/StandardTestClientBuilder.java:
##
@@ -72,6 +74,12 @@ public TestCli
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1769073337
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ===
garydgregory commented on code in PR #580:
URL:
https://github.com/apache/httpcomponents-client/pull/580#discussion_r1768647926
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/DecompressEntity.java:
##
@@ -0,0 +1,160 @@
+/*
+ * ===
Cedric Tabin created HTTPCLIENT-2342:
Summary: Regression: Content-Type header not returned anymore
Key: HTTPCLIENT-2342
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2342
Project: HttpComp
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cedric Tabin updated HTTPCLIENT-2342:
-
Description:
Hello,
We just upgraded today to httpclient5 version 5.4. It seems tha
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cedric Tabin updated HTTPCLIENT-2342:
-
Description:
Hello,
We just upgraded today to httpclient5 version 5.4. It seems tha
Please lazy vote on releasing HttpComponents CheckStyle 3 based on RC1.
The vote is open for the at least 72 hours, and only votes from HttpComponents
PMC members are binding. The vote passes if at least one binding +1 vote is
cast and there are more +1 than -1 votes.
Maven repo:
https://repos
garydgregory commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-client/pull/581#discussion_r1768663895
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java:
##
@@ -403,9 +404,15 @@ void verifySession(
45 matches
Mail list logo
