Re: [PR] HTTPCLIENT-1625 Completely overhaul GSS-API-based authentication backend [httpcomponents-client]

2024-09-09 Thread via GitHub
stoty commented on code in PR #577: URL: https://github.com/apache/httpcomponents-client/pull/577#discussion_r1749779212 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/GGSSchemeBase.java: ## @@ -138,7 +236,9 @@ protected byte[] generateGSSToken( fina

Re: [PR] HTTPCLIENT-1625 Completely overhaul GSS-API-based authentication backend [httpcomponents-client]

2024-09-09 Thread via GitHub
michael-o commented on code in PR #577: URL: https://github.com/apache/httpcomponents-client/pull/577#discussion_r1749784415 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/GGSSchemeBase.java: ## @@ -138,7 +236,9 @@ protected byte[] generateGSSToken(

[jira] [Updated] (HTTPCLIENT-2337) Potentially unsafe logging of X500Principal in SSLConnectionSocketFactory

2024-09-09 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-2337: -- Fix Version/s: Stuck (was: 5.4-beta2) Lab

Re: [PR] HTTPCLIENT-1625 Completely overhaul GSS-API-based authentication backend [httpcomponents-client]

2024-09-09 Thread via GitHub
michael-o commented on code in PR #577: URL: https://github.com/apache/httpcomponents-client/pull/577#discussion_r1749832476 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/GGSSchemeBase.java: ## @@ -138,7 +236,9 @@ protected byte[] generateGSSToken(

Re: [PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]

2024-09-09 Thread via GitHub
michael-o commented on PR #578: URL: https://github.com/apache/httpcomponents-client/pull/578#issuecomment-2337635254 Just read the spec, the flag is fine, but consider that NTLM is dead in general. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: HttpCore 5.3 release notes

2024-09-09 Thread Gary Gregory
Minor edits. LGTM! Thank you Oleg! Gary On Mon, Sep 9, 2024, 1:19 AM Oleg Kalnichevski wrote: > Folks > > Please review and amend HttpCore 5.3 release notes as you deem necessary > > https://github.com/apache/httpcomponents-core/blob/master/RELEASE_NOTES.txt > > Oleg > > ---

[VOTE] Release HttpCore 5.3 based on RC1

2024-09-09 Thread Oleg Kalnichevski
Please vote on releasing these packages as HttpCore 5.3. The vote is open for the at least 72 hours, and only votes from HttpComponents PMC members are binding. The vote passes if at least three binding +1 votes are cast and there are more +1 than -1 votes. Release notes: https://dist.apache.org