Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-19 Thread via GitHub
massdosage commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2296104023 @ok2c thanks, I took a look, we haven't used the `DefaultHostnameVerifier` component so I'm not entirely sure of its intended uses, especially with respect to wildcard cer

Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-19 Thread via GitHub
ok2c commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2296220740 @massdosage RFC 9525 is a new document which HttpClient does not conform to yet. What we need to ensure that HttpClient conforms to [RFC2818](https://datatracker.ietf.org/doc/ht

Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-19 Thread via GitHub
massdosage commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2296391196 OK, for RFC2818 it looks like one just needs to implement the wildcard at the "level" in the domain name it's specified but not any "lower". One could do that with just st

Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-19 Thread via GitHub
ok2c commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2296886308 @massdosage Committed as 715ec110600c2f0ee5c4fa03085306db175afba5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Update PublicSuffixMatcher to use "formal algorithm" [httpcomponents-client]

2024-08-19 Thread via GitHub
ok2c closed pull request #566: Update PublicSuffixMatcher to use "formal algorithm" URL: https://github.com/apache/httpcomponents-client/pull/566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HTTPCLIENT-2336) Update PublicSuffixMatcher to use "formal algorithm"

2024-08-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874917#comment-17874917 ] ASF subversion and git services commented on HTTPCLIENT-2336:

[jira] [Commented] (HTTPCLIENT-2336) Update PublicSuffixMatcher to use "formal algorithm"

2024-08-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874918#comment-17874918 ] ASF subversion and git services commented on HTTPCLIENT-2336:

[jira] [Resolved] (HTTPCLIENT-2336) Update PublicSuffixMatcher to use "formal algorithm"

2024-08-19 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2336. --- Fix Version/s: 5.4-beta2 (was: Future) Reso