Re: (httpcomponents-core) 01/03: Revert "Remove needless null comparisons"

2024-06-11 Thread Oleg Kalnichevski
Hi Gary Please kindly avoid pushing those micro-commits straight into release branches just to end up reverting them a few minutes later. Please commit your changes to a feature branch first, review and merge once reviewed. And permit others to review as well. Oleg On Mon, 2024-06-10 at 22:00

Re: (httpcomponents-core) 01/03: Revert "Remove needless null comparisons"

2024-06-11 Thread Gary Gregory
Hi Oleg, Understood. I will take time to add the missing unit tests that would have caught the initial mistake in the first place. Hopefully this week. Gary On Tue, Jun 11, 2024, 3:08 AM Oleg Kalnichevski wrote: > Hi Gary > > Please kindly avoid pushing those micro-commits straight into rele

Unit tests; Re: (httpcomponents-core) 01/03: Revert "Remove needless null comparisons"

2024-06-11 Thread Oleg Kalnichevski
On Tue, 2024-06-11 at 07:34 -0400, Gary Gregory wrote: > Hi Oleg, > > Understood. I will take time to add the missing unit tests that would > have caught the initial mistake in the first place. Hopefully this > week.  > Do you want me to hold off 5.3 BETA1 for that or can those unit tests integr

[jira] [Commented] (HTTPCLIENT-2328) Request hangs if TLS 1.3 connection is half-closed

2024-06-11 Thread Zoe Wang (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854103#comment-17854103 ] Zoe Wang commented on HTTPCLIENT-2328: -- [~olegk], I did more testing, and it se

[jira] [Commented] (HTTPCLIENT-2328) Request hangs if TLS 1.3 connection is half-closed

2024-06-11 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854161#comment-17854161 ] Oleg Kalnichevski commented on HTTPCLIENT-2328: --- [~Zoe Wang] Has `Mana

[jira] [Commented] (HTTPCLIENT-2328) Request hangs if TLS 1.3 connection is half-closed

2024-06-11 Thread Zoe Wang (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854190#comment-17854190 ] Zoe Wang commented on HTTPCLIENT-2328: -- Yeah, doesn't seem so (didn't realize `