[PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
crazylulululu opened a new pull request, #465: URL: https://github.com/apache/httpcomponents-core/pull/465 the logic is incorrect ,if a connection is used continuously , it will generate the G1 Humongous Allocation , and GC will be particularly frequent, please fix this bug as soon as pos

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
crazylulululu commented on PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082359208 ![image](https://github.com/apache/httpcomponents-core/assets/42406448/db7f8364-4760-4a52-ad53-c1da2a29e35c) -- This is an automated message from the Apache Git Ser

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
ok2c commented on PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082386349 @crazylulululu Do you think you could add a test case for this defect to `TestHPackCoding`? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
crazylulululu commented on PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082418772 > @crazylulululu Do you think you could add a test case for this defect to `TestHPackCoding`? OK, use this.tmpBuf.position() + extra as the requiredCapacity is

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
ok2c commented on PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082425684 > > @crazylulululu Do you think you could add a test case for this defect to `TestHPackCoding`? > > OK, use this.tmpBuf.position() + extra as the requiredCapacity is error ,

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
crazylulululu commented on PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082495455 @ok2c , I have add the test case ,please help to check , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
ok2c commented on code in PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#discussion_r1583023593 ## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackDecoder.java: ## @@ -158,6 +158,10 @@ void decodeString(final ByteArrayBuffer buffer, final

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
crazylulululu commented on code in PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#discussion_r1583366968 ## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackDecoder.java: ## @@ -158,6 +158,10 @@ void decodeString(final ByteArrayBuffer buffer

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
ok2c merged PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] fix the G1 Humongous Allocation BUG, when the connection run all the … [httpcomponents-core]

2024-04-29 Thread via GitHub
ok2c commented on PR #465: URL: https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2083253924 @crazylulululu Merged to `5.2.x` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to