wangkaish opened a new pull request, #557:
URL: https://github.com/apache/httpcomponents-client/pull/557
Update the method parameter of InetAddressUtils from String to CharSequence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
garydgregory commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2008585993
@wangkaish
You'll need to _add_ tests that exercise CharSequence parameter values.
--
This is an automated message from the Apache Git Service.
To respond to the me
wangkaish commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2008608253
Hi @garydgregory
String is an implementation of CharSequence, and the test argument used in
TestInetAddressUtils is String, so I don't think we need a test case with a
garydgregory commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2008643813
Changing the API from a class to an interface has no such behavioral
guarantee, even if the API binary compatibility is maintained.
IOW there is no proof that the
