ok2c commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1448459822
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory() {
ok2c commented on PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#issuecomment-1886597928
> As it stands, there's no way for createSocket(HttpContext to be called
anymore
@Sineaggi So what? This method will get removed in the next major release. I
do not see h
twarner-sofi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1449129972
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFac
ok2c commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1449148318
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory() {
twarner-sofi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1449152364
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFac
ok2c commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1449254785
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory() {
twarner-sofi commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1449275956
##
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##
@@ -63,7 +63,7 @@ public PlainConnectionSocketFac
