[jira] [Commented] (HTTPCORE-757) AbstractCharDataConsumer jams up with incomplete UTF-8 data

2023-09-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761800#comment-17761800 ] ASF subversion and git services commented on HTTPCORE-757: -- Co

[jira] [Commented] (HTTPCORE-757) AbstractCharDataConsumer jams up with incomplete UTF-8 data

2023-09-04 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761802#comment-17761802 ] Oleg Kalnichevski commented on HTTPCORE-757: [~simon.white] Please review /

[GitHub] [httpcomponents-core] ok2c commented on pull request #427: Support SOCKS5 proxy with username/password authentication

2023-09-04 Thread via GitHub
ok2c commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705145516 @yndu13 Looks correct to me. I am still trying to test the fix locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication

2023-09-04 Thread via GitHub
yndu13 commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705165517 > @yndu13 Looks correct to me. I am still trying to test the fix locally. Thanks, you can use this [socks server](https://github.com/serjs/socks5-server) to verify this pr

[GitHub] [httpcomponents-core] garydgregory commented on pull request #427: Support SOCKS5 proxy with username/password authentication

2023-09-04 Thread via GitHub
garydgregory commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705169527 Hi @yndu13 Thank you for your PR. Without a matching test, this change in behavior can be undone in the future without anyone noticing. -- This is an automated me

[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication

2023-09-04 Thread via GitHub
yndu13 commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705190444 > Hi @yndu13 Thank you for your PR. Without a matching test, this change in behavior can be undone in the future without anyone noticing. I agree with this opinion, but th

[GitHub] [httpcomponents-core] ok2c merged pull request #427: Support SOCKS5 proxy with username/password authentication

2023-09-04 Thread via GitHub
ok2c merged PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-core] ok2c commented on pull request #427: Support SOCKS5 proxy with username/password authentication

2023-09-04 Thread via GitHub
ok2c commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705224802 > Thanks, you can use this [socks server](https://github.com/serjs/socks5-server) to verify this problem. @yndu13 I tested it with [Dante](https://www.inet.no/dante/). --

[jira] [Commented] (HTTPCORE-757) AbstractCharDataConsumer jams up with incomplete UTF-8 data

2023-09-04 Thread Simon White (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761876#comment-17761876 ] Simon White commented on HTTPCORE-757: -- Hi [~olegk]. I've tested that and it's wo