[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

ok2c commented on code in PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#discussion_r1233310473 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheValidityPolicy.java: ## @@ -206,28 +206,51 @@ protected TimeValue getApparentAge

[GitHub] [httpcomponents-client] ok2c commented on pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

ok2c commented on PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#issuecomment-1596158581 @arturobernalg The way I read `RFC 9111 5.1` the client would be able to handle `Age` values like `123, 123, 0` or `123, 123, crap` and take the first value from the token list

Re: [VOTE] Release HttpCore 5.2.2 based on RC2

Hi, +1, for httpcore5-h2. Tested memory consumption issue fix. Thanks, Sandeep Gaur On Fri, Jun 16, 2023 at 7:40 PM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.2.2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC memb

[GitHub] [httpcomponents-client] ok2c opened a new pull request, #458: HTTPCLIENT-2277, HTTPCLIENT-1347: Revision of the variant handling by the HTTP cache implementations

ok2c opened a new pull request, #458: URL: https://github.com/apache/httpcomponents-client/pull/458 Revision of the variant handling by the HTTP cache implementations * Cache entries now can be of two distinct types: root entries containing a map of known representation variants of th

[GitHub] [httpcomponents-client] ok2c commented on pull request #458: HTTPCLIENT-2277, HTTPCLIENT-1347: Revision of the variant handling by the HTTP cache implementations

ok2c commented on PR #458: URL: https://github.com/apache/httpcomponents-client/pull/458#issuecomment-1596184965 @arturobernalg Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

arturobernalg commented on code in PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#discussion_r1233374525 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestProtocolRequirements.java: ## @@ -2123,7 +2123,13 @@ public void testAg

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

arturobernalg commented on code in PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#discussion_r1233374549 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheValidityPolicy.java: ## @@ -206,28 +206,51 @@ protected TimeValue getAp

[GitHub] [httpcomponents-client] arturobernalg closed pull request #457: Check if is Suitable Variant

arturobernalg closed pull request #457: Check if is Suitable Variant URL: https://github.com/apache/httpcomponents-client/pull/457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

ok2c commented on code in PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#discussion_r1233376104 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestProtocolRequirements.java: ## @@ -2123,7 +2123,13 @@ public void testAgeHeaderPo

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

arturobernalg commented on code in PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#discussion_r1233380617 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestProtocolRequirements.java: ## @@ -2123,7 +2123,13 @@ public void testAg

[GitHub] [httpcomponents-client] arturobernalg commented on pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

arturobernalg commented on PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#issuecomment-1596269768 > @arturobernalg What happens when you get `Age: 123crap` header? > > It is great that you are trying to make your code efficient but in this case it is getting a

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

ok2c commented on code in PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#discussion_r1233386929 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheValidityPolicy.java: ## @@ -206,28 +207,60 @@ protected TimeValue getApparentAge

Re: [VOTE] Release HttpCore 5.2.2 based on RC2

On 6/16/2023 7:38 PM, Oleg Kalnichevski wrote: --- Vote: HttpCore 5.2.2 release [X] +1 Release the packages as HttpCore 5.2.2. [ ] -1 I am against releasing the packages (must include a reason) asankha -- Asankha C. Perera Aayu Technologies LLC, https://aayutechnologies.com AdroitLogic, http

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #456: HTTPCLIENT-2277: Improve Age Header Handling and Calculation in Accordance with RFC9111.

ok2c commented on code in PR #456: URL: https://github.com/apache/httpcomponents-client/pull/456#discussion_r1233603220 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheValidityPolicy.java: ## @@ -206,28 +207,62 @@ protected TimeValue getApparentAge