[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
ok2c commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225286200 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpCacheEntryMatcher.java: ## @@ -92,6 +91,41 @@ public boolean matches(final Object

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
ok2c commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225286200 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpCacheEntryMatcher.java: ## @@ -92,6 +91,41 @@ public boolean matches(final Object

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
ok2c commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225286591 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java: ## @@ -230,316 +233,174 @@ public HttpCacheSt

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
ok2c commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225287521 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java: ## @@ -163,57 +125,98 @@ public HttpByteArray

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
ok2c commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225287909 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheUpdateHandler.java: ## @@ -123,18 +128,29 @@ public HttpCacheEntry updateParentC

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
arturobernalg commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225463198 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpCacheEntryMatcher.java: ## @@ -92,6 +91,41 @@ public boolean matches(fin

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
arturobernalg commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225463198 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpCacheEntryMatcher.java: ## @@ -92,6 +91,41 @@ public boolean matches(fin

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
ok2c commented on code in PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453#discussion_r1225501313 ## httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpCacheEntryMatcher.java: ## @@ -92,6 +91,41 @@ public boolean matches(final Object

[GitHub] [httpcomponents-client] ok2c merged pull request #453: HTTPCLIENT-2277: Redesign of the internal cache serialization format

2023-06-10 Thread via GitHub
ok2c merged PR #453: URL: https://github.com/apache/httpcomponents-client/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[jira] [Commented] (HTTPCLIENT-2277) HttpClient Cache conformance to RFC 9111

2023-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731236#comment-17731236 ] ASF subversion and git services commented on HTTPCLIENT-2277:

[jira] [Commented] (HTTPCLIENT-2277) HttpClient Cache conformance to RFC 9111

2023-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731237#comment-17731237 ] ASF subversion and git services commented on HTTPCLIENT-2277: