[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #431: Enable IDN conversion for scheme port resolver

2023-04-04 Thread via GitHub
arturobernalg commented on code in PR #431: URL: https://github.com/apache/httpcomponents-client/pull/431#discussion_r1157490537 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java: ## @@ -751,6 +766,26 @@ public CloseableHttpClient build

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #430: Add support for proxy failover

2023-04-04 Thread via GitHub
arturobernalg commented on code in PR #430: URL: https://github.com/apache/httpcomponents-client/pull/430#discussion_r1157517970 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/routing/FailoverProxySelector.java: ## @@ -0,0 +1,123 @@ +/* + * ===

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
arturobernalg commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157540582 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,680 @@ +/* + *

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
arturobernalg commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157542710 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,680 @@ +/* + *

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
arturobernalg commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157540582 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,680 @@ +/* + *

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
arturobernalg commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157542710 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,680 @@ +/* + *

[GitHub] [httpcomponents-client] rschmitt commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
rschmitt commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157606106 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,680 @@ +/* + * =

[GitHub] [httpcomponents-client] rschmitt commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
rschmitt commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157609000 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,680 @@ +/* + * =

[GitHub] [httpcomponents-client] rhernandez35 commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
rhernandez35 commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157856752 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,680 @@ +/* + * =

[GitHub] [httpcomponents-client] rhernandez35 commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
rhernandez35 commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157860807 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,697 @@ +/* + * =

[GitHub] [httpcomponents-client] rhernandez35 commented on a diff in pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator

2023-04-04 Thread via GitHub
rhernandez35 commented on code in PR #428: URL: https://github.com/apache/httpcomponents-client/pull/428#discussion_r1157861324 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/HappyEyeballsV2AsyncClientConnectionOperator.java: ## @@ -0,0 +1,697 @@ +/* + * =