Re: Replacement for ConnectionSocketFactory

2025-04-11 Thread Ryan Schmitt
DefaultHttpClientConnectionOperator is marked @Internal, as is the associated connection manager constructor that takes an instance of it. I'll take a look at your other suggestions. On Fri, Apr 11, 2025 at 4:34 AM Oleg Kalnichevski wrote: > > On Thu, 2025-04-10 at 19:02 -0700, Ryan Schmitt wrote

Re: Replacement for ConnectionSocketFactory

2025-04-11 Thread Ryan Schmitt
Marking incubating interfaces as @Internal as fair. I sometimes use @Deprecated, since the call sites generate warnings that way, but the @Internal convention is good to know. On Fri, Apr 11, 2025 at 3:00 PM Ryan Schmitt wrote: > > DefaultHttpClientConnectionOperator is marked @Internal, as is th

Re: Replacement for ConnectionSocketFactory

2025-04-11 Thread Oleg Kalnichevski
On Thu, 2025-04-10 at 19:02 -0700, Ryan Schmitt wrote: > 2. Connection count metrics. This is a trivial CSF implementation > that > wraps a delegate and emits a metric whenever connectSocket() is > called. > 3. Unix domain socket support. This is a CSF implementation that > calls > JUnixSocket to c

Replacement for ConnectionSocketFactory

2025-04-10 Thread Ryan Schmitt
I'm working on a long-overdue upgrade of HttpClient5 from the 5.2 series to 5.4.3. I've noticed that ConnectionSocketFactory has been deprecated. This interface was previously responsible for both creating sockets, as well as upgrading existing sockets to TLS; the latter functionality was exposed t