ok2c merged PR #589:
URL: https://github.com/apache/httpcomponents-client/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
ok2c commented on PR #589:
URL:
https://github.com/apache/httpcomponents-client/pull/589#issuecomment-2414924711
> @ok2c The changes look reasonable to me, even though I don't have prior
experience with `TestContainers`.
@arturobernalg Honestly, nether do it. It is a learning process
massdosage commented on code in PR #589:
URL:
https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801578332
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java:
##
@@ -0,0 +1,156 @@
+/*
ok2c commented on code in PR #589:
URL:
https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801194855
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java:
##
@@ -0,0 +1,156 @@
+/*
+ * ==
massdosage commented on code in PR #589:
URL:
https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801162862
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java:
##
@@ -0,0 +1,156 @@
+/*
ok2c commented on code in PR #589:
URL:
https://github.com/apache/httpcomponents-client/pull/589#discussion_r1801130025
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/sync/CachingHttpClientCompatibilityTest.java:
##
@@ -0,0 +1,156 @@
+/*
+ * ==
massdosage commented on code in PR #589:
URL:
https://github.com/apache/httpcomponents-client/pull/589#discussion_r1800751636
##
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/compatibility/ContainerImages.java:
##
@@ -0,0 +1,119 @@
+/*
+ *