Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

ok2c commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2940952494 > Windows CI builds were disabled in 2022 due to "intermittent network failures." I'm not sure what that means. Do any of these tests talk to the internet? @rschmitt @gar

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

rschmitt commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2940919155 https://github.com/apache/httpcomponents-client/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

rschmitt commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2940910411 Windows CI builds were disabled in 2022 due to "intermittent network failures." I'm not sure what that means. Do any of these tests talk to the internet? -- This is an au

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

garydgregory commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2940860203 We need Windows tests in the CI I think: ``` [ERROR] Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.043 s <<< FAILURE! -- in org.apache.hc.clien

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

rschmitt merged PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

ok2c commented on code in PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#discussion_r2126500077 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestConnectionTimeouts.java: ## @@ -0,0 +1,106 @@ +/* + *

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

garydgregory commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2936932290 Odd that the tests fail only on macOS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

garydgregory commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2937066143 I saw these failures: https://github.com/apache/httpcomponents-client/actions/runs/15425891897 We're they random? -- This is an automated message from

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

rschmitt commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2937082576 Those are JDK17/JDK21 failures occasioned by a change in capitalization. JDK8 and JDK11 report `connect timed out`, while JDK17 and JDK21 report `Connect timed out`.

Re: [PR] Add integration tests for connection timeouts [httpcomponents-client]

rschmitt commented on PR #640: URL: https://github.com/apache/httpcomponents-client/pull/640#issuecomment-2936989548 They do? I _developed_ them on macOS, and my `/etc/hosts` file doesn't have an entry for the address I'm using. -- This is an automated message from the Apache Git Service