garydgregory commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2909744186
@reschke
Thanks you for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
reschke commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2899223046
> The fact that QUERY is technically a different method doesn't eliminate
the inconsistencies; it just shifts them. Introducing QUERY as a workaround for
the issues with GET bo
ok2c merged PR #499:
URL: https://github.com/apache/httpcomponents-core/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apac
ok2c commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2444907619
If I hear no objections I will merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424201126
Or just not merge it now. I don't know if there's a policy regarding PR
status and longevity, but I could also just move this to a draft PR and
> @desiderantes @gar
ok2c commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424194167
@desiderantes @garydgregory @arturobernalg We can make the new method as
`@Experimental` and even `@Internal` until the standardisation is complete. I
personally do not see a prob
ok2c commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424233009
@desiderantes
```
Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.21.2:cmp (default) on project
httpcore5: There is at least one incompatibility:
o
ok2c commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424214497
@desiderantes `japicmp` does not like new fields added to `@Experimenal`.
Just add a comment next to it to keep `japicmp` happy.
--
This is an automated message from the Apache
garydgregory commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424204077
> > Or just not merge it now. I don't know if there's a policy regarding PR
status and longevity, but I could also just move this to a draft PR and
> > > @desiderantes @
arturobernalg commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424201670
> @desiderantes @garydgregory @arturobernalg We can mark the new method as
`@Experimental` and even `@Internal` until the standardisation is complete. I
personally do not
ok2c commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424202498
> Or just not merge it now. I don't know if there's a policy regarding PR
status and longevity, but I could also just move this to a draft PR and
>
> > @desiderantes @garydg
garydgregory commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424199493
> > An explicit failure mode (not supporting unknown/custom HTTP methods) is
substantially better than mishandled request bodies, so I'd say it is not a
shift, but an enfo
garydgregory commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424200308
> @desiderantes @garydgregory @arturobernalg We can mark the new method as
`@Experimental` and even `@Internal` until the standardisation is complete. I
personally do not
arturobernalg commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424193593
> An explicit failure mode (not supporting unknown/custom HTTP methods) is
substantially better than mishandled request bodies, so I'd say it is not a
shift, but an enfor
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424189940
> > I do not understand the argument about inconsistencies of GET with
bodies, this is a different method, services would either support it or not. I
think that's the main
arturobernalg commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424184854
> I do not understand the argument about inconsistencies of GET with bodies,
this is a different method, services would either support it or not. I think
that's the main
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424181093
> > > > > I have a couple of concerns regarding the addition of the QUERY
method:
> > > >
> > > >
> > > > Sure
> > > > > ```
> > > > > * Lack of Standardiz
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424168835
> > > I have a couple of concerns regarding the addition of the QUERY method:
> >
> >
> > Sure
> > > ```
> > > * Lack of Standardization: The QUERY method i
arturobernalg commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424176249
> > > > I have a couple of concerns regarding the addition of the QUERY
method:
> > >
> > >
> > > Sure
> > > > ```
> > > > * Lack of Standardization: The
garydgregory commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424165151
> > I think it would be good to carry standard Javadoc tags like param,
return, throws, whatever is appropriate for that element. For the description,
I like to be able to
garydgregory commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424163948
> > I have a couple of concerns regarding the addition of the QUERY method:
>
> Sure
>
> > ```
> > * Lack of Standardization: The QUERY method isn't defined
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424162591
> I think it would be good to carry standard Javadoc tags like param,
return, throws, whatever is appropriate for that element. For the description,
I like to be able to u
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424160249
> A draft and not a finalized standard
I think a major web framework adding it pushes forward the need for support
by a lot, since there will be services using it no
garydgregory commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424160216
> > Hi @desiderantes I'd like to see all new public and protected elements
come with Javadoc (with since tags).
>
> Besides a since tag, what else should the builder
arturobernalg commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424153453
> > I have a couple of concerns regarding the addition of the QUERY method:
>
> Sure
>
> > ```
> > * Lack of Standardization: The QUERY method isn't define
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424151161
> Hi @desiderantes I'd like to see all new public and protected elements
come with Javadoc (with since tags).
Besides a since tag, what else should the builder metho
desiderantes commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424150863
> I have a couple of concerns regarding the addition of the QUERY method:
Sure
> * Lack of Standardization: The QUERY method isn't defined in any
official
arturobernalg commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424150056
I have a couple of concerns regarding the addition of the QUERY method:
- Lack of Standardization: The QUERY method isn't defined in any official
HTTP specification
arturobernalg commented on PR #499:
URL:
https://github.com/apache/httpcomponents-core/pull/499#issuecomment-2424148867
@desiderantes From my understanding, the QUERY method is not defined in any
official HTTP specification
--
This is an automated message from the Apache Git Service.
T
30 matches
Mail list logo
