Re: [PR] Update the method parameter from String to CharSequence. [httpcomponents-core]

2024-03-22 Thread via GitHub
ok2c merged PR #462: URL: https://github.com/apache/httpcomponents-core/pull/462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] Update the method parameter from String to CharSequence. [httpcomponents-core]

2024-03-21 Thread via GitHub
ok2c commented on PR #462: URL: https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2011603034 @wangkaish There are style-check violations. Please address them. Please also add `@since 5.3` to a;; new methods. Otherwise looks good. -- This is an automated message from the

Re: [PR] Update the method parameter from String to CharSequence. [httpcomponents-core]

2024-03-20 Thread via GitHub
wangkaish commented on PR #462: URL: https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2011021839 @ok2c There is a method named `isIPv4MappedIPv64Address` in InetAddressUtils, is that mean `isIPv4MappedIPv6Address`? -- This is an automated message from the Apache Git Se

Re: [PR] Update the method parameter from String to CharSequence. [httpcomponents-core]

2024-03-20 Thread via GitHub
ok2c commented on PR #462: URL: https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2009194371 @wangkaish You do something like that https://github.com/ok2c/httpcomponents-core/commit/96ca1afe17af5e7e4973b21579adf9ebd5a10a69 -- This is an automated message from the Apache

Re: [PR] Update the method parameter from String to CharSequence. [httpcomponents-core]

2024-03-20 Thread via GitHub
ok2c commented on PR #462: URL: https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2009196175 > but in fact the API is compatible @wangkaish No, it is not. It is compile compatible but binary incompatible. -- This is an automated message from the Apache Git Service. To

Re: [PR] Update the method parameter from String to CharSequence. [httpcomponents-core]

2024-03-20 Thread via GitHub
wangkaish commented on PR #462: URL: https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2009107247 Hi, @ok2c CI indicates that version compatibility check failed, but in fact the API is compatible, what do I do in this case? -- This is an automated message from the Apac

[PR] Update the method parameter from String to CharSequence. [httpcomponents-core]

2024-03-20 Thread via GitHub
wangkaish opened a new pull request, #462: URL: https://github.com/apache/httpcomponents-core/pull/462 Update the method parameter of InetAddressUtils from String to CharSequence. Sometimes I need to pass parts of a String(create a String slice) to this method instead of splitting the