ok2c merged PR #527:
URL: https://github.com/apache/httpcomponents-core/pull/527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apac
ok2c commented on PR #527:
URL:
https://github.com/apache/httpcomponents-core/pull/527#issuecomment-2963439457
@farahaniali All right. That makes more sense. I will merge the change-set
to master but not to the stable 5.3.x branch for now. We will see how the TLS
code behaves in the coming
farahaniali commented on PR #527:
URL:
https://github.com/apache/httpcomponents-core/pull/527#issuecomment-2963287934
> @farahaniali If can propose a safe-guard that does not involve a magic
number like 1000 I will happily review.
@ok2c Just update the PR.
Reaching this if block m
ok2c commented on PR #527:
URL:
https://github.com/apache/httpcomponents-core/pull/527#issuecomment-2962871023
@farahaniali If can propose a safe-guard that does not involve a magic
number like 1000 I will happily review.
--
This is an automated message from the Apache Git Service.
To re
arturobernalg commented on PR #527:
URL:
https://github.com/apache/httpcomponents-core/pull/527#issuecomment-2962379375
@farahaniali IMO Hard-coding a 1 000-cycle guard is just another band-aid.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
farahaniali commented on PR #527:
URL:
https://github.com/apache/httpcomponents-core/pull/527#issuecomment-2962297354
@ok2c and @garydgregory do not disagree with the fact that this is the
simplest and arbitrary looking solution. Open to suggestion so I can
incorporate any available mechan
garydgregory commented on PR #527:
URL:
https://github.com/apache/httpcomponents-core/pull/527#issuecomment-2962277800
I agree with @ok2c , this type of change may be acceptable for local
debugging but it doesn't belong in production. You may want to gather use case
specific metrics and re
ok2c commented on PR #527:
URL:
https://github.com/apache/httpcomponents-core/pull/527#issuecomment-2962249560
@farahaniali This work-around is hideous. I would prefer a proper fix to the
problem instead.
--
This is an automated message from the Apache Git Service.
To respond to the mess
farahaniali opened a new pull request, #527:
URL: https://github.com/apache/httpcomponents-core/pull/527
As a safety net for handling an infinite loop happening inside decrypt
method (that has been reported here
https://issues.apache.org/jira/browse/HTTPCORE-782), we propose a unproductive
