sratz commented on PR #552:
URL:
https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2623843069
> @sratz `context.setCookieStore(cookieStore);` will work correctly
regardless of the version. What changed in 5.4 is that standard attributes no
longer get shoved into a map.
ok2c commented on PR #552:
URL:
https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622662274
> only looks at the attributes, not at the getter methods:
@sratz `context.setCookieStore(cookieStore);` will work correctly regardless
of the version. What changed in 5.4
sratz commented on PR #552:
URL:
https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622607194
I think the problem is that `HttpClientContext` never kept the well-known
named attributes and their equivalent object member in sync, i.e.
`setAttribute("http.cookie-sto
sratz commented on PR #552:
URL:
https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622594563
> > does not solve the problem, as that would work in 5.4, but not in 5.3
anymore.
>
> @sratz Why would not that work in 5.3?
Because there the reverse is true,
`
ok2c commented on PR #552:
URL:
https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622515880
> does not solve the problem, as that would work in 5.4, but not in 5.3
anymore.
@sratz Why would not that work in 5.3?
--
This is an automated message from the Apache
sratz commented on PR #552:
URL:
https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622456032
This change is incompatible.
Consider when a *consumer* sets the attributes on the context:
```java
BasicCookieStore cookieStore = new BasicCookieStore();
Htt
ok2c merged PR #552:
URL: https://github.com/apache/httpcomponents-client/pull/552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
ok2c commented on PR #552:
URL:
https://github.com/apache/httpcomponents-client/pull/552#issuecomment-1961436304
@arturobernalg Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ok2c opened a new pull request, #552:
URL: https://github.com/apache/httpcomponents-client/pull/552
* Aligns client context APIs with those in core
* Context classes are now plain beans
* Backward compatibility with older versions (through internal Delegate
classes)
* Javadoc imprve
