arturobernalg merged PR #500:
URL: https://github.com/apache/httpcomponents-core/pull/500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
arturobernalg commented on code in PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#discussion_r1811122466
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ResponseDate.java:
##
@@ -46,27 +46,49 @@
* This interceptor is recommended for the HTTP
ok2c commented on code in PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#discussion_r1810132671
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ResponseDate.java:
##
@@ -46,27 +46,49 @@
* This interceptor is recommended for the HTTP protocol
ok2c commented on code in PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#discussion_r1810132671
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ResponseDate.java:
##
@@ -46,27 +46,49 @@
* This interceptor is recommended for the HTTP protocol
arturobernalg commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2427284467
> By the way `status >= HttpStatus.SC_OK` check can be removed, as 1xx
intermediate response messages never get passed to the protocol handler along
with final responses.
ok2c commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2427019299
@arturobernalg Yes, pretty much, but with a boolean flag (`alwaysReplace or
some such`) like you had before.
By the way `status >= HttpStatus.SC_OK` check can be removed, a
arturobernalg commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2426943351
> @arturobernalg Looks unnecessary complex. So what if the `DATE` can be
successfully parsed but it represents a point in time when Jesus roamed
Galilea? What good that t
ok2c commented on PR #500:
URL:
https://github.com/apache/httpcomponents-core/pull/500#issuecomment-2426462442
@arturobernalg Looks unnecessary complex. So what if the `DATE` can be
successfully parsed but it represents a point in time when Jesus roamed
Galilea? What good that that make? I
arturobernalg opened a new pull request, #500:
URL: https://github.com/apache/httpcomponents-core/pull/500
This pull request optimizes the handling of the Date header in HTTP
responses by ensuring that invalid Date headers are correctly replaced with the
current time when necessary, followi
