Re: [PR] Be null-aware when handling failures in HTTP 1 streams [httpcomponents-core]

2025-02-12 Thread via GitHub
ok2c closed pull request #515: Be null-aware when handling failures in HTTP 1 streams URL: https://github.com/apache/httpcomponents-core/pull/515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Be null-aware when handling failures in HTTP 1 streams [httpcomponents-core]

2025-02-12 Thread via GitHub
ok2c commented on PR #515: URL: https://github.com/apache/httpcomponents-core/pull/515#issuecomment-2654114910 @CelestiaTheDryad There were multiple issues / defects related to this issue. I also found a defect in the client-side async HTTP/1.1 protocol handler while working on a reproduce

Re: [PR] Be null-aware when handling failures in HTTP 1 streams [httpcomponents-core]

2025-02-12 Thread via GitHub
ok2c commented on PR #515: URL: https://github.com/apache/httpcomponents-core/pull/515#issuecomment-2654116733 @CelestiaTheDryad Please pull the latest `5.3.x` or `master` and test the fixes in your local environment. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Be null-aware when handling failures in HTTP 1 streams [httpcomponents-core]

2025-02-11 Thread via GitHub
ok2c commented on PR #515: URL: https://github.com/apache/httpcomponents-core/pull/515#issuecomment-2652132732 @CelestiaTheDryad Thank you for reporting the issue and proposing a solution. I do not quite like the fact that the fix involves a creation of a fake request and also would like

Re: [PR] Be null-aware when handling failures in HTTP 1 streams [httpcomponents-core]

2025-02-11 Thread via GitHub
garydgregory commented on PR #515: URL: https://github.com/apache/httpcomponents-core/pull/515#issuecomment-2651029610 Hello @CelestiaTheDryad Would you be able to create a test that reproduces the issue? The test should fail if the changes to the main side of the tree are not appli

[PR] Be null-aware when handling failures in HTTP 1 streams [httpcomponents-core]

2025-02-10 Thread via GitHub
CelestiaTheDryad opened a new pull request, #515: URL: https://github.com/apache/httpcomponents-core/pull/515 Using version 5.3.1 We were experiencing spontaneous closures of our HTTP servers from this library. I traced the behavior to this stacktrace. It is caused by an exception oc