Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-16 Thread via GitHub
rschmitt merged PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-16 Thread via GitHub
rschmitt commented on PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#issuecomment-2977254110 @ok2c Anything else on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-10 Thread via GitHub
rschmitt commented on code in PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#discussion_r2138372541 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestAsyncSocketTimeout.java: ## @@ -0,0 +1,166 @@ +/* + * ===

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-10 Thread via GitHub
rschmitt commented on PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#issuecomment-2959988932 > This is yet another limitation of the classic i/o one must tolerate. Yeah, this is probably one reason why virtually all server IO is non-blocking, even when the API

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-10 Thread via GitHub
rschmitt commented on code in PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#discussion_r2138292205 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/async/AsyncRandomHandler.java: ## @@ -192,6 +216,10 @@ public int availableData() {

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-10 Thread via GitHub
rschmitt commented on code in PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#discussion_r2138289061 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/async/AsyncRandomHandler.java: ## @@ -93,6 +93,20 @@ public void handleRequest(

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-10 Thread via GitHub
ok2c commented on PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#issuecomment-2958055260 > I was startled to learn that `java.net.Socket::setSoTimeout` only sets _read_ timeouts: > > https://github.com/openjdk/jdk/blob/d186dacdb7b91dc9a28b703ce3c8ea007fc450b6

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-10 Thread via GitHub
ok2c commented on code in PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#discussion_r2137130664 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/async/AsyncRandomHandler.java: ## @@ -93,6 +93,20 @@ public void handleRequest( }

[PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-09 Thread via GitHub
rschmitt opened a new pull request, #648: URL: https://github.com/apache/httpcomponents-client/pull/648 This change adds integration test coverage for various types of read timeouts. The test coverage includes HTTP, HTTPS, and HTTP over UDS if available. The `/random` request handlers have

Re: [PR] Add socket timeout integration tests [httpcomponents-client]

2025-06-09 Thread via GitHub
rschmitt commented on PR #648: URL: https://github.com/apache/httpcomponents-client/pull/648#issuecomment-2957181561 I was startled to learn that `java.net.Socket::setSoTimeout` only sets _read_ timeouts: https://github.com/openjdk/jdk/blob/d186dacdb7b91dc9a28b703ce3c8ea007fc450b6/s