Re: [PR] Add integration tests for TLS handshake timeouts [httpcomponents-client]

2025-06-05 Thread via GitHub
rschmitt merged PR #644: URL: https://github.com/apache/httpcomponents-client/pull/644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: Change in GC behavior since 5.2.1?

2025-06-05 Thread Ryan Schmitt
Finalizers are deprecated for removal: https://openjdk.org/jeps/421 I don't think there's any particular requirement for the HttpClient to tolerate this sort of misuse, but it is nevertheless a change in behavior and I wanted to get to the bottom of it. On Thu, Jun 5, 2025 at 5:35 AM Oleg Kalnic

Re: [PR] Omit cookie spec registry when cookie management is disabled [httpcomponents-client]

2025-06-05 Thread via GitHub
rschmitt merged PR #645: URL: https://github.com/apache/httpcomponents-client/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: [PR] Omit cookie spec registry when cookie management is disabled [httpcomponents-client]

2025-06-05 Thread via GitHub
rschmitt commented on PR #645: URL: https://github.com/apache/httpcomponents-client/pull/645#issuecomment-2945868341 @PascalSchumacher I think this is the wrong default behavior and I plan on dealing with it next. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956434#comment-17956434 ] Oleg Kalnichevski commented on HTTPCORE-783: [~ggregory] This does not answ

[jira] [Commented] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-05 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956426#comment-17956426 ] Gary D. Gregory commented on HTTPCORE-783: -- > I do remember a discussion that

[jira] [Commented] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956425#comment-17956425 ] Michael Osipov commented on HTTPCORE-783: - I do remember a discussion that is n

[jira] [Commented] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-05 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956409#comment-17956409 ] Gary D. Gregory commented on HTTPCORE-783: -- According to [https://www.rfc-edit

Re: [PR] Omit cookie spec registry when cookie management is disabled [httpcomponents-client]

2025-06-05 Thread via GitHub
PascalSchumacher commented on PR #645: URL: https://github.com/apache/httpcomponents-client/pull/645#issuecomment-2945234272 👍 but in most cases the full public suffix list will be loaded by `DefaultHostnameVerifier` later on. -- This is an automated message from the Apache Git Service.

[jira] [Resolved] (HTTPCLIENT-2372) Redirection to same target with sensitive headers is not followed

2025-06-05 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved HTTPCLIENT-2372. --- Resolution: Fixed > Redirection to same target with sensitive headers is not fol

[jira] [Closed] (HTTPCLIENT-2372) Redirection to same target with sensitive headers is not followed

2025-06-05 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed HTTPCLIENT-2372. - > Redirection to same target with sensitive headers is not followed > --

[jira] [Commented] (HTTPCLIENT-2372) Redirection to same target with sensitive headers is not followed

2025-06-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956397#comment-17956397 ] ASF subversion and git services commented on HTTPCLIENT-2372:

Re: [PR] HTTPCLIENT-2372 - Normalize HttpHost port comparison to treat implicit default ports as equal [httpcomponents-client]

2025-06-05 Thread via GitHub
arturobernalg merged PR #643: URL: https://github.com/apache/httpcomponents-client/pull/643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[jira] [Commented] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956368#comment-17956368 ] Oleg Kalnichevski commented on HTTPCORE-783: [~ggregory]  Are these content

[jira] [Comment Edited] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956368#comment-17956368 ] Oleg Kalnichevski edited comment on HTTPCORE-783 at 6/5/25 2:28 PM: -

Re: Change in GC behavior since 5.2.1?

2025-06-05 Thread Gary Gregory
I think it is worth noting that GC behavior can not only differ between Java versions but can also be affected by JVM command line parameters. So explaing GC precisely as it relates to our code in an application is very difficult. Gary On Thu, Jun 5, 2025, 08:35 Oleg Kalnichevski wrote: > Hi Ry

[jira] [Created] (HTTPCORE-783) ContentType should implement equals() and hashCode()

2025-06-05 Thread Gary D. Gregory (Jira)
Gary D. Gregory created HTTPCORE-783: Summary: ContentType should implement equals() and hashCode() Key: HTTPCORE-783 URL: https://issues.apache.org/jira/browse/HTTPCORE-783 Project: HttpComponents

[PR] Add ContentType.APPLICATION_ZIP_COMPRESSED [httpcomponents-core]

2025-06-05 Thread via GitHub
garydgregory opened a new pull request, #524: URL: https://github.com/apache/httpcomponents-core/pull/524 Add ContentType.APPLICATION_ZIP_COMPRESSED. I ran into this one at work this week... -- This is an automated message from the Apache Git Service. To respond to the message,

Re: Change in GC behavior since 5.2.1?

2025-06-05 Thread Oleg Kalnichevski
Hi Ryan The reproducer stopped working for me (I use Ubuntu Linux) but this no longer matters. I think there is a reasonable explanation as to why it now may take two GC cycles to fully reclaim file descriptors in case of a connection pool going out of scope without being properly shut down. I th

Re: [PR] HTTPCLIENT-2372 - Normalize HttpHost port comparison to treat implicit default ports as equal [httpcomponents-client]

2025-06-05 Thread via GitHub
arturobernalg commented on code in PR #643: URL: https://github.com/apache/httpcomponents-client/pull/643#discussion_r2128558691 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/DefaultRedirectStrategy.java: ## @@ -80,6 +83,36 @@ public boolean isRedirectAllowed(

[jira] [Commented] (HTTPCLIENT-2372) Redirection to same target with sensitive headers is not followed

2025-06-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956313#comment-17956313 ] Michael Osipov commented on HTTPCLIENT-2372: A protocol upgrade should b

[jira] [Commented] (HTTPCLIENT-2373) HTTP proxy returns 400 when connection was established before

2025-06-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956310#comment-17956310 ] Oleg Kalnichevski commented on HTTPCLIENT-2373: --- [~beth4soptim] Basica

[jira] [Resolved] (HTTPCLIENT-2373) HTTP proxy returns 400 when connection was established before

2025-06-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2373. --- Resolution: Invalid > HTTP proxy returns 400 when connection was establi

Re: [PR] Add integration tests for TLS handshake timeouts [httpcomponents-client]

2025-06-05 Thread via GitHub
ok2c commented on code in PR #644: URL: https://github.com/apache/httpcomponents-client/pull/644#discussion_r2128264258 ## httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestTlsHandshakeTimeout.java: ## @@ -0,0 +1,118 @@ +/* + * ===

[jira] [Commented] (HTTPCLIENT-2373) HTTP proxy returns 400 when connection was established before

2025-06-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956305#comment-17956305 ] Oleg Kalnichevski commented on HTTPCLIENT-2373: --- [~beth4soptim] I do n

[jira] [Commented] (HTTPCLIENT-2372) Redirection to same target with sensitive headers is not followed

2025-06-05 Thread Jonathan Yan (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956297#comment-17956297 ] Jonathan Yan commented on HTTPCLIENT-2372: -- Another case that is kind of re

[jira] [Updated] (HTTPCLIENT-2373) HTTP proxy returns 400 when connection was established before

2025-06-05 Thread Thomas Beckers (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Beckers updated HTTPCLIENT-2373: --- Description: The following code makes a HTTP request that returns 400 from the p

[jira] [Created] (HTTPCLIENT-2373) HTTP proxy returns 400 when connection was established before

2025-06-05 Thread Thomas Beckers (Jira)
Thomas Beckers created HTTPCLIENT-2373: -- Summary: HTTP proxy returns 400 when connection was established before Key: HTTPCLIENT-2373 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2373 Pro

Re: Use of PublicSuffixMatcher in DefaultHostnameVerifier

2025-06-05 Thread Oleg Kalnichevski
On Wed, 2025-06-04 at 16:08 -0700, Ryan Schmitt wrote: > Why does the default hostname verifier, as returned by > HttpsSupport.getDefaultHostnameVerifier(), check DNS names against > the > public suffix list? I don't think I've seen this behavior elsewhere, > and publicsuffix.org doesn't list this

Re: [PR] Add integration tests for TLS handshake timeouts [httpcomponents-client]

2025-06-05 Thread via GitHub
ok2c commented on PR #644: URL: https://github.com/apache/httpcomponents-client/pull/644#issuecomment-2943225324 @rschmitt Presently all timeouts supported by HC represent the maximum period of inactivity between consecutive i/o operations and not a deadline. There is feature request for r

Re: [PR] HTTPCLIENT-2372 - Normalize HttpHost port comparison to treat implicit default ports as equal [httpcomponents-client]

2025-06-05 Thread via GitHub
ok2c commented on code in PR #643: URL: https://github.com/apache/httpcomponents-client/pull/643#discussion_r2128241605 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/DefaultRedirectStrategy.java: ## @@ -80,6 +83,36 @@ public boolean isRedirectAllowed( re