Re: [PR] DNS host / identity normalization should be performed only once per public API call [httpcomponents-client]

2025-04-04 Thread via GitHub
massdosage commented on code in PR #629: URL: https://github.com/apache/httpcomponents-client/pull/629#discussion_r2022416194 ## httpclient5/src/test/java/org/apache/hc/client5/http/psl/TestPublicSuffixMatcher.java: ## @@ -284,14 +284,14 @@ void testGetDomainRootPublicSuffixLis

Re: [PR] Bump log4j.version from 2.23.1 to 2.24.3 [httpcomponents-client]

2025-04-04 Thread via GitHub
garydgregory merged PR #626: URL: https://github.com/apache/httpcomponents-client/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

[jira] [Created] (HTTPCLIENT-2363) execute(HttpHost, HttpRequest, ResponseHandler) adds port to Host header while execute(HttpRequest, ResponseHandler) does not

2025-04-04 Thread Nicholas O'Connor (Jira)
Nicholas O'Connor created HTTPCLIENT-2363: - Summary: execute(HttpHost, HttpRequest, ResponseHandler) adds port to Host header while execute(HttpRequest, ResponseHandler) does not Key: HTTPCLIENT-2363 URL:

Re: [PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.1 [httpcomponents-client]

2025-04-04 Thread via GitHub
garydgregory merged PR #623: URL: https://github.com/apache/httpcomponents-client/pull/623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

Re: [PR] DNS host / identity normalization should be performed only once per public API call [httpcomponents-client]

2025-04-04 Thread via GitHub
ok2c commented on code in PR #629: URL: https://github.com/apache/httpcomponents-client/pull/629#discussion_r2021132196 ## httpclient5/src/test/java/org/apache/hc/client5/http/psl/TestPublicSuffixMatcher.java: ## @@ -284,14 +284,14 @@ void testGetDomainRootPublicSuffixList() {

Re: [PR] HTTPCLIENT-2365, regression: corrected handling of private domains by PublicSuffixMatcher [httpcomponents-client]

2025-04-04 Thread via GitHub
leonardehrenfried commented on PR #628: URL: https://github.com/apache/httpcomponents-client/pull/628#issuecomment-2765261270 I tried it in my application and can confirm that I can download URLs from `s3.amazonaws.com`. -- This is an automated message from the Apache Git Service. To res

Re: Deprecation of MIME support in HttpClient

2025-04-04 Thread Oleg Kalnichevski
Folks Can we make a decision of some sort? Michael, you seem to prefer we continue to support MIME in HttpClient. What we can do is to add a statement to the HttpClient 5.5 release notes that we are considering dropping support for MIME entities in HttpClient in favor of Apache Mime4J and ask t

[jira] [Commented] (HTTPCLIENT-2364) Close IMMEDIATE does not work properly on HTTPS-upgraded connection through proxy

2025-04-04 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939476#comment-17939476 ] Oleg Kalnichevski commented on HTTPCLIENT-2364: --- [~farraultdedge] Your

[jira] [Updated] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated HTTPCLIENT-2366: -- Fix Version/s: 5.4.4 > HttpClient5 - RequestEntityProxy#isRepeatable incorrectly r

Re: [PR] HTTPCLIENT-2366 - Fix isRepeatable method in RequestEntityProxy to return true before consumption. [httpcomponents-client]

2025-04-04 Thread via GitHub
arturobernalg commented on PR #630: URL: https://github.com/apache/httpcomponents-client/pull/630#issuecomment-2779274568 > @arturobernalg Please cherry-pick to `5.4.x` done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941029#comment-17941029 ] ASF subversion and git services commented on HTTPCLIENT-2366:

[jira] [Commented] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940988#comment-17940988 ] Oleg Kalnichevski commented on HTTPCLIENT-2366: --- > if we’d opened a PR

Re: [PR] HTTPCLIENT-2366 - Fix isRepeatable method in RequestEntityProxy to return true before consumption. [httpcomponents-client]

2025-04-04 Thread via GitHub
ok2c commented on PR #630: URL: https://github.com/apache/httpcomponents-client/pull/630#issuecomment-2779204894 @arturobernalg Please cherry-pick to `5.4.x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] HTTPCLIENT-2366 - Fix isRepeatable method in RequestEntityProxy to return true before consumption. [httpcomponents-client]

2025-04-04 Thread via GitHub
arturobernalg merged PR #630: URL: https://github.com/apache/httpcomponents-client/pull/630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[jira] [Resolved] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved HTTPCLIENT-2366. --- Resolution: Fixed > HttpClient5 - RequestEntityProxy#isRepeatable incorrectly re

[jira] [Commented] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941020#comment-17941020 ] ASF subversion and git services commented on HTTPCLIENT-2366:

[PR] HTTPCLIENT-2366 - Fix isRepeatable method in RequestEntityProxy to return true before consumption. [httpcomponents-client]

2025-04-04 Thread via GitHub
arturobernalg opened a new pull request, #630: URL: https://github.com/apache/httpcomponents-client/pull/630 This PR fixes an issue with the `isRepeatable` method in `RequestEntityProxy`. Previously, if the underlying entity was non-repeatable, the proxy would incorrectly return false even

[jira] [Comment Edited] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940992#comment-17940992 ] Gary D. Gregory edited comment on HTTPCLIENT-2366 at 4/4/25 2:14 PM: -

[jira] [Commented] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940992#comment-17940992 ] Gary D. Gregory commented on HTTPCLIENT-2366: - I create a PR with a unit

[jira] [Commented] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940974#comment-17940974 ] Arturo Bernal commented on HTTPCLIENT-2366: --- [~ggregory]   if we’d opened

[jira] [Commented] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940964#comment-17940964 ] Gary D. Gregory commented on HTTPCLIENT-2366: - Hm, it probably should be

[jira] [Updated] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Nicklas Wallgren (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicklas Wallgren updated HTTPCLIENT-2366: - Description: The behavior of {{RequestEntityProxy#isRepeatable}} changed in 

[jira] [Created] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed

2025-04-04 Thread Nicklas Wallgren (Jira)
Nicklas Wallgren created HTTPCLIENT-2366: Summary: HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed Key: HTTPCLIENT-2366 URL: https://issues.apache.org/jira