Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-17 Thread via GitHub
TomerAberbach commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2731270909 Okay, I hear you, but did my comment help explain why I think this change would be disruptive if it's not released as a major version bump? Do you have any thoughts on

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-17 Thread via GitHub
garydgregory commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2731264747 Hello @TomerAberbach We normally reserve major version bumps for breaking binary compatibility as defined by the JLS, which is not the case here. -- This i

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-17 Thread via GitHub
TomerAberbach commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2731261012 Hey folks, I'm a software engineer at [Stainless](https://stainless.com). We generate Java/Kotlin SDKs and they all use `MultipartEntityBuilder` from this library.

[PR] Use a random boundary value by default [httpcomponents-client]

2025-03-17 Thread via GitHub
benweissmann opened a new pull request, #625: URL: https://github.com/apache/httpcomponents-client/pull/625 See more context in discussion from #619. The advantage of using a random boundary by default are: - It's in line with the behavior recommended by RFC 2046, [as discussed her

Re: [PR] [HTTPCLIENT-1843] - Delegate compression handling to Apache Commons Compress [httpcomponents-client]

2025-03-17 Thread via GitHub
arturobernalg commented on PR #580: URL: https://github.com/apache/httpcomponents-client/pull/580#issuecomment-2730403554 Hi @garydgregory , do I need to do anything else for PR #[580](https://github.com/apache/httpcomponents-client/pull/580)? Any timing to validate it? Thanks! -- This

Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-17 Thread via GitHub
ok2c commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2729077927 @outlandishlizard So, you happily ignored the main point and proceeded to tell me the good old tale if thousands of monkeys bang away at a type writer long enough they will even

Re: [VOTE] Release HttpCore 5.3.4 based on RC1

2025-03-17 Thread Oleg Kalnichevski
[x] +1 Release the packages as HttpCore 5.3.4 Oleg On Sun, 2025-03-16 at 10:08 +0100, Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.3.4. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes i

Re: [PR] Disallow automatic request redirection if the original request contains potentially sensitive headers [httpcomponents-client]

2025-03-17 Thread via GitHub
ok2c merged PR #624: URL: https://github.com/apache/httpcomponents-client/pull/624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

Re: [VOTE] Release HttpCore 5.3.4 based on RC1

2025-03-17 Thread Arturo Bernal
+1 Release the packages as HttpCore 5.3.4. Arturo On Sun, Mar 16, 2025 at 10:08 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.3.4. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes i