[jira] [Commented] (HTTPCORE-778) Inconsistency in encoding method for query and fragment components by URIBuilder

2025-03-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935514#comment-17935514 ] ASF subversion and git services commented on HTTPCORE-778: -- Co

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
arturobernalg commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1996253015 ## httpcore5/src/main/java/org/apache/hc/core5/net/PercentCodec.java: ## @@ -113,6 +113,37 @@ public class PercentCodec { RFC5987_UNRESERVED.s

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
ok2c commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1995800177 ## httpcore5/src/main/java/org/apache/hc/core5/net/PercentCodec.java: ## @@ -113,6 +113,37 @@ public class PercentCodec { RFC5987_UNRESERVED.set('~');

[PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.1 [httpcomponents-client]

2025-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #623: URL: https://github.com/apache/httpcomponents-client/pull/623 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.jun

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
arturobernalg commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1995792098 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -391,14 +438,16 @@ private String buildString() { formatQuer

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
ok2c commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1995772108 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -391,14 +438,16 @@ private String buildString() { formatQuery(sb, thi

Re: [PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [httpcomponents-client]

2025-03-14 Thread via GitHub
dependabot[bot] closed pull request #620: Bump org.junit:junit-bom from 5.11.4 to 5.12.0 URL: https://github.com/apache/httpcomponents-client/pull/620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [httpcomponents-client]

2025-03-14 Thread via GitHub
dependabot[bot] commented on PR #620: URL: https://github.com/apache/httpcomponents-client/pull/620#issuecomment-2724746965 Superseded by #623. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
ok2c commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1995524429 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -87,9 +87,36 @@ public static URIBuilder loopbackAddress() { private Charset char

[jira] [Resolved] (HTTPCORE-778) Inconsistency in encoding method for query and fragment components by URIBuilder

2025-03-14 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-778. Resolution: Fixed Fixed in 5.3.x and master. Oleg > Inconsistency in encoding m

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
peterhalicky commented on PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#issuecomment-2724567181 > The same could be done for the fragment component. The fragment component often contains all kinds of content. Sometimes it is `application/x-www-form-urlencoded`, oth

Re: [PR] HTTPCORE-778: URIBuilder to not encode sub-delims in URI fragment component for consistency with query component encoding [httpcomponents-core]

2025-03-14 Thread via GitHub
ok2c merged PR #518: URL: https://github.com/apache/httpcomponents-core/pull/518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
ok2c commented on PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#issuecomment-2724577476 @peterhalicky Those folks who need this stuff are welcome to build their own builders. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
ok2c commented on PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#issuecomment-2724547404 > I just wanted to point out that this is still a restriction that will not allow users to create all possible URIs that would otherwise be legal as per the RFC @peterhali

[jira] [Commented] (HTTPCORE-778) Inconsistency in encoding method for query and fragment components by URIBuilder

2025-03-14 Thread Peter Halicky (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935495#comment-17935495 ] Peter Halicky commented on HTTPCORE-778: [~olegk] thank you for the invite, I'v

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
ok2c commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1995335981 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -391,14 +438,16 @@ private String buildString() { formatQuery(sb, thi

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
arturobernalg commented on code in PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#discussion_r1995090045 ## httpcore5/src/main/java/org/apache/hc/core5/net/PercentCodec.java: ## @@ -84,6 +84,16 @@ public class PercentCodec { URIC.or(UNRESERVED);

Re: [PR] Fix percent-encoding in fragment identifiers per RFC 3986 [httpcomponents-core]

2025-03-14 Thread via GitHub
arturobernalg commented on PR #517: URL: https://github.com/apache/httpcomponents-core/pull/517#issuecomment-2723977979 > > @arturobernalg What about `userinfo`, `reg-name`, path `segment?` > > @ok2c here's a consolidated fix ensuring consistent RFC 3986–compliant encoding for userin