Re: [PR] MultipartEntityBuilder to use a fixed boundary by a default [httpcomponents-client]

2025-03-08 Thread via GitHub
benweissmann commented on PR #619: URL: https://github.com/apache/httpcomponents-client/pull/619#issuecomment-2708467305 Is there a reason to default to the fixed boundary rather than the secure-random boundary? I think the only time it's safe to use a fixed boundary is if there's no user-

Re: [PR] Fix race condition between response submission thread and IO thread [httpcomponents-core]

2025-03-08 Thread via GitHub
ok2c commented on PR #516: URL: https://github.com/apache/httpcomponents-core/pull/516#issuecomment-2708326779 > I question why the application thread is doing this work at all though. The general design of this library seems to treat each connection as a single threaded environment. With

Re: [PR] Fix race condition between response submission thread and IO thread [httpcomponents-core]

2025-03-08 Thread via GitHub
ok2c commented on PR #516: URL: https://github.com/apache/httpcomponents-core/pull/516#issuecomment-2708325915 @CelestiaTheDryad My apologies it has taken me so long I think I have managed to fix the concurrency issues without resorting to thread synchronization. (I did try using an

[jira] [Commented] (HTTPCORE-777) CloseableHttpAsyncClient.execute hangs forever upon connection reset

2025-03-08 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932991#comment-17932991 ] Oleg Kalnichevski commented on HTTPCORE-777: [~oleksandrkriuchenko]  # Her

[jira] [Commented] (HTTPCORE-777) CloseableHttpAsyncClient.execute hangs forever upon connection reset

2025-03-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933510#comment-17933510 ] ASF subversion and git services commented on HTTPCORE-777: -- Co

Re: [PR] HTTPCLIENT-2358 Implement a mutual authentication capable SPNEGO scheme [httpcomponents-client]

2025-03-08 Thread via GitHub
stoty commented on PR #615: URL: https://github.com/apache/httpcomponents-client/pull/615#issuecomment-2708153331 I hope I got all the fixes we discussed, @michael-o . Based on my digging, I have set isConnectionBased() to false. I have also fixed the logic in the needAuthentic