Re: [PR] Redesign of client HTTP context APIs [httpcomponents-client]

2025-01-29 Thread via GitHub
ok2c commented on PR #552: URL: https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622662274 > only looks at the attributes, not at the getter methods: @sratz `context.setCookieStore(cookieStore);` will work correctly regardless of the version. What changed in 5.4

Re: [PR] Redesign of client HTTP context APIs [httpcomponents-client]

2025-01-29 Thread via GitHub
sratz commented on PR #552: URL: https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622607194 I think the problem is that `HttpClientContext` never kept the well-known named attributes and their equivalent object member in sync, i.e. `setAttribute("http.cookie-sto

Re: [PR] Redesign of client HTTP context APIs [httpcomponents-client]

2025-01-29 Thread via GitHub
sratz commented on PR #552: URL: https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622594563 > > does not solve the problem, as that would work in 5.4, but not in 5.3 anymore. > > @sratz Why would not that work in 5.3? Because there the reverse is true, `

[ANNOUNCEMENT] HttpComponents Core 5.3.3 GA released

2025-01-29 Thread Oleg Kalnichevski
The Apache HttpComponents project is pleased to announce 5.3.3 GA release of HttpComponents Core. This maintenance release fixes a defect in how asynchronous SSL sessions handle an overflow condition when encrypting application data. There have also been several fixes for edge cases related to han

Re: [PR] Redesign of client HTTP context APIs [httpcomponents-client]

2025-01-29 Thread via GitHub
ok2c commented on PR #552: URL: https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622515880 > does not solve the problem, as that would work in 5.4, but not in 5.3 anymore. @sratz Why would not that work in 5.3? -- This is an automated message from the Apache

[jira] [Commented] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922173#comment-17922173 ] Arturo Bernal commented on HTTPCLIENT-2359: --- [~olegk]  Oh, I completely fo

Re: [PR] Redesign of client HTTP context APIs [httpcomponents-client]

2025-01-29 Thread via GitHub
sratz commented on PR #552: URL: https://github.com/apache/httpcomponents-client/pull/552#issuecomment-2622456032 This change is incompatible. Consider when a *consumer* sets the attributes on the context: ```java BasicCookieStore cookieStore = new BasicCookieStore(); Htt

Re: [VOTE] Release HttpClient 5.4.2 based on RC1

2025-01-29 Thread Arturo Bernal
+1 Release the packages as HttpClient 5.4.2 Arturo On Tue, Jan 28, 2025 at 8:01 PM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.4.2. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes

[jira] [Resolved] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov resolved HTTPCLIENT-2359. --- Resolution: Implemented Ok. I will try Httpclient5 > Retry HTTP request

[jira] [Comment Edited] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922085#comment-17922085 ] Oleg Kalnichevski edited comment on HTTPCLIENT-2359 at 1/29/25 1:18 PM: --

[jira] [Commented] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922085#comment-17922085 ] Oleg Kalnichevski commented on HTTPCLIENT-2359: --- > would still produce

[jira] [Commented] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922078#comment-17922078 ] Arturo Bernal commented on HTTPCLIENT-2359: --- I believe this is a regressio

[jira] [Commented] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922077#comment-17922077 ] Vladimir Sitnikov commented on HTTPCLIENT-2359: --- [~olegk], thanks for

Re: [VOTE] Release HttpClient 5.4.2 based on RC1

2025-01-29 Thread Gary Gregory
+1 I tested the src zip file: - ASC OK - SHA512 OK - mvn clean verify -P'!use-toolchains' Using Maven 3.9.9 on Java 17, 21, 23. openjdk version "17.0.14" 2025-01-21 OpenJDK Runtime Environment Homebrew (build 17.0.14+0) OpenJDK 64-Bit Server VM Homebrew (build 17.0.14+0, mixed mode, sharing) Ap

[jira] [Commented] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922071#comment-17922071 ] Oleg Kalnichevski commented on HTTPCLIENT-2359: --- [~vladimirsitnikov] A

[jira] [Comment Edited] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922062#comment-17922062 ] Oleg Kalnichevski edited comment on HTTPCLIENT-2359 at 1/29/25 11:21 AM: -

[jira] [Commented] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922062#comment-17922062 ] Oleg Kalnichevski commented on HTTPCLIENT-2359: --- [~vladimirsitnikov] T

[jira] [Updated] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated HTTPCLIENT-2359: -- Description: See https://www.rfc-editor.org/rfc/rfc2068#section-8.2 {quot

[jira] [Created] (HTTPCLIENT-2359) Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2

2025-01-29 Thread Vladimir Sitnikov (Jira)
Vladimir Sitnikov created HTTPCLIENT-2359: - Summary: Retry HTTP requests if server closes connection before sending status line as per RFC 2068, 8.2 Key: HTTPCLIENT-2359 URL: https://issues.apache.org/jira