[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #484: HTTPCLIENT-2277: deprecation of obsolete config parameters and removal of oudated or meaningless tests

2023-09-19 Thread via GitHub
ok2c commented on code in PR #484: URL: https://github.com/apache/httpcomponents-client/pull/484#discussion_r1330654678 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheConfig.java: ## @@ -257,11 +232,11 @@ public int getMaxUpdateRetries(){ }

[jira] [Commented] (HTTPCLIENT-2277) HttpClient Cache conformance to RFC 9111

2023-09-19 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766913#comment-17766913 ] Arturo Bernal commented on HTTPCLIENT-2277: --- [~olegk]  I'll review all th

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #484: HTTPCLIENT-2277: deprecation of obsolete config parameters and removal of oudated or meaningless tests

2023-09-19 Thread via GitHub
arturobernalg commented on code in PR #484: URL: https://github.com/apache/httpcomponents-client/pull/484#discussion_r1330608339 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheConfig.java: ## @@ -257,11 +232,11 @@ public int getMaxUpdateRetries(){

Re: [VOTE] Release HttpCore 5.2.3 based on RC1

2023-09-19 Thread Michael Osipov
Am 2023-09-17 um 11:22 schrieb Oleg Kalnichevski: Please vote on releasing these packages as HttpCore 5.2.3. The vote is open for the at least 72 hours, and only votes from HttpComponents PMC members are binding. The vote passes if at least three binding +1 votes are cast and there are more +1 th

[GitHub] [httpcomponents-core] arturobernalg closed pull request #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110

2023-09-19 Thread via GitHub
arturobernalg closed pull request #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110 URL: https://github.com/apache/httpcomponents-core/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110

2023-09-19 Thread via GitHub
arturobernalg commented on PR #430: URL: https://github.com/apache/httpcomponents-core/pull/430#issuecomment-1726330738 > * This change-set is definitely useful, but it kind of goes counter to the overall philosophy of the library. Generally we provide higher level APIs for consumers to us

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #428: Add validation for :path pseudo-header in HTTP/2 requests RFC7540

2023-09-19 Thread via GitHub
arturobernalg commented on code in PR #428: URL: https://github.com/apache/httpcomponents-core/pull/428#discussion_r1330579222 ## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/DefaultH2RequestConverter.java: ## @@ -208,4 +210,39 @@ public List convert(final HttpRequ

Re: [VOTE] Release HttpCore 5.2.3 based on RC1

2023-09-19 Thread Oleg Kalnichevski
[x] +1 Release the packages as HttpCore 5.2.3 On Sun, 2023-09-17 at 11:22 +0200, Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.2.3. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at l

[jira] [Commented] (HTTPCORE-757) AbstractCharDataConsumer jams up with incomplete UTF-8 data

2023-09-19 Thread Simon White (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766680#comment-17766680 ] Simon White commented on HTTPCORE-757: -- [~olegk] Sorry for the delay here, I was o