[GitHub] [httpcomponents-client] arturobernalg commented on pull request #418: Fix issue with LLv6 literals in URLs

2023-03-02 Thread via GitHub
arturobernalg commented on PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#issuecomment-1452512057 HI @ok2c Even though I don't fully agree with putting logic in the catch block, I made the change. I believe it's better to keep it separate." TY -- This is an

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-02 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1123306774 ## httpclient5/src/test/java/org/apache/hc/client5/http/SystemDefaultDnsResolverTest.java: ## @@ -0,0 +1,68 @@ +/* + * ===