[GitHub] [httpcomponents-core] arturobernalg commented on pull request #387: Added ViaRequest interceptor

2023-02-08 Thread via GitHub
arturobernalg commented on PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#issuecomment-1423181889 > @arturobernalg Please change the target branch to `5.3.x`. @ok2c Done -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutput

2023-02-08 Thread via GitHub
arturobernalg commented on PR #386: URL: https://github.com/apache/httpcomponents-core/pull/386#issuecomment-1423181592 > @arturobernalg 1. Please change the target branch to `5.3.x`. 2. I see 2 more instances of `new File*Stream`. Please replace them as well. @ok2c Done -- This i

[GitHub] [httpcomponents-core] ok2c commented on pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutputStream()

2023-02-08 Thread via GitHub
ok2c commented on PR #386: URL: https://github.com/apache/httpcomponents-core/pull/386#issuecomment-1422427841 @arturobernalg 1. Please change the target branch to `5.3.x`. 2. I see 2 more instances of `new File*Stream`. Please replace them as well. -- This is an automated message from t

[GitHub] [httpcomponents-core] ok2c commented on pull request #387: Added ViaRequest interceptor

2023-02-08 Thread via GitHub
ok2c commented on PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#issuecomment-1422421657 @arturobernalg Please change the target branch to `5.3.x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [httpcomponents-core] dependabot[bot] closed pull request #384: Bump mockito-core from 4.11.0 to 5.1.1

2023-02-08 Thread via GitHub
dependabot[bot] closed pull request #384: Bump mockito-core from 4.11.0 to 5.1.1 URL: https://github.com/apache/httpcomponents-core/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [httpcomponents-core] dependabot[bot] commented on pull request #384: Bump mockito-core from 4.11.0 to 5.1.1

2023-02-08 Thread via GitHub
dependabot[bot] commented on PR #384: URL: https://github.com/apache/httpcomponents-core/pull/384#issuecomment-1422408027 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. 😢 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [httpcomponents-core] ok2c commented on pull request #384: Bump mockito-core from 4.11.0 to 5.1.1

2023-02-08 Thread via GitHub
ok2c commented on PR #384: URL: https://github.com/apache/httpcomponents-core/pull/384#issuecomment-1422407973 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: EntityUtils.toByteArray gets very slow in downloading large content with unknown content-length

2023-02-08 Thread Oleg Kalnichevski
On Wed, 2023-02-08 at 19:21 +0900, 石田隼也 wrote: > Hi, our team uses `EntityUtils.toByteArray` method in > `org.apache.httpcomponents:httpcore:4.4.15` to implement HTTP client > to download a file. > > We found that file download gets very slow when downloading a file of > ~1.7 GB. Based on our inve

EntityUtils.toByteArray gets very slow in downloading large content with unknown content-length

2023-02-08 Thread 石田隼也
Hi, our team uses `EntityUtils.toByteArray` method in `org.apache.httpcomponents:httpcore:4.4.15` to implement HTTP client to download a file. We found that file download gets very slow when downloading a file of ~1.7 GB. Based on our investigation, the performance of copying the response to a