Re: Enhanced for-loops

2018-11-24 Thread Ryan Schmitt
Where's the grief, exactly? The fact that these objects are showing up in heap dumps does not imply performance impact, and no performance impact was claimed, nor were any measurements provided. To state that iterators "have to be garbage collected" is misleading; the Java garbage collector traces

Re: Enhanced for-loops

2018-11-24 Thread Gary Gregory
On Sat, Nov 24, 2018 at 7:37 AM Oleg Kalnichevski wrote: > On Sat, 2018-11-24 at 15:04 +0100, Michael Osipov wrote: > > Am 2018-11-23 um 09:20 schrieb Oleg Kalnichevski:> On Thu, 2018-11-22 > > at > > 20:12 -0700, Gary Gregory wrote: > > >> Hi All: > > >> > > >> In the HC code base, we could a

Re: UriPatternMatcher.map is not sorted

2018-11-24 Thread Gary Gregory
On Sat, Nov 24, 2018 at 7:02 AM Michael Osipov wrote: > Am 2018-11-21 um 20:23 schrieb Gary Gregory: > > On Wed, Nov 21, 2018 at 11:20 AM Michael Osipov > wrote: > > > >> Am 2018-11-21 um 19:05 schrieb Gary Gregory: > >>> Hi All: > >>> > >>> I am going to change > >>> org.apache.hc.core5.http.pr

Re: Enhanced for-loops

2018-11-24 Thread Oleg Kalnichevski
On Sat, 2018-11-24 at 15:04 +0100, Michael Osipov wrote: > Am 2018-11-23 um 09:20 schrieb Oleg Kalnichevski:> On Thu, 2018-11-22 > at > 20:12 -0700, Gary Gregory wrote: > >> Hi All: > >> > >> In the HC code base, we could avoid some boilerplate clutter by > using > >> Java's enhanced for-loop

Re: Enhanced for-loops

2018-11-24 Thread Michael Osipov
Am 2018-11-23 um 09:20 schrieb Oleg Kalnichevski:> On Thu, 2018-11-22 at 20:12 -0700, Gary Gregory wrote: >> Hi All: >> >> In the HC code base, we could avoid some boilerplate clutter by using >> Java's enhanced for-loop construct. I believe this would make the >> code >> easier to read. Are ther

Re: UriPatternMatcher.map is not sorted

2018-11-24 Thread Michael Osipov
Am 2018-11-21 um 20:23 schrieb Gary Gregory: On Wed, Nov 21, 2018 at 11:20 AM Michael Osipov wrote: Am 2018-11-21 um 19:05 schrieb Gary Gregory: Hi All: I am going to change org.apache.hc.core5.http.protocol.UriPatternMatcher.map from a HashMap to a LinkedHashMap. This is to allow a rever