Re: Potential enhancement to type checking extensions

2024-05-01 Thread Paul King
Just to come back to this discussion. The existing functionality is what I ended up using in this blog post: https://groovy.apache.org/blog/multiversal-equality In that post, you can see two code fragments that start with "afterVisitMethod" and contain code using the type checking extension DSL.

Re: Potential enhancement to type checking extensions

2024-05-01 Thread MG
Hi Paul, 1. if this /is /to be supported, I would still argue for the more general approach. 2. However, having scanned the blog post, it seems to me the case for having this kind of support is quite weak. 1. E.g. change of color code library leading to assertion failing for the

Re: Potential enhancement to type checking extensions

2024-05-01 Thread Paul King
Thanks mg, comments inline. On Thu, May 2, 2024 at 2:51 AM MG wrote: > > Hi Paul, > > if this is to be supported, I would still argue for the more general approach. Both potential tweaks that I looked at did use the more general approach. > However, having scanned the blog post, it seems to me

Re: Potential enhancement to type checking extensions

2024-05-01 Thread MG
@Both potential tweaks that I looked at did use the more general approach: Assumed as much, just wanted to emphasize this, before I argued that maybe we don't need this at all. I think my argument holds for the more general example you (or Scala) gives, I don't know if this is worth the effort,