Groovy 2.5.4 generates dead code

2018-11-21 Thread Andres Almiray
Hello everyone, Evgeny Mandrikov (from JaCoCo) sent me a message regarding dead code produced by Groovy 2.5.4 (see https://github.com/jacoco/jacoco/pull/733#issuecomment-440030323 in context). Reproducing full message: @aalmiray while playing further with Groovy, I

Aw: Groovy 2.5.4 generates dead code

2018-11-21 Thread Jochen Theodorou
Hi Andres,   there was at some point in the past (I think it was related to Java8) a problem with us doing entries into the exception table (I think it was that table). There was no fix to this on any simple or middle level. The entry was made like that because of how the data is processed in As

Re: Aw: Groovy 2.5.4 generates dead code

2018-11-21 Thread Remi Forax
The history from the ASM point of view, starting with Java 6, the VM starts to use a new bytecode verifier which is linear in time and not exponential like the previous one but it requires to annotate with a StackMap attribute the bytecode with the state of the local types and the stack types m

Re: Aw: Groovy 2.5.4 generates dead code

2018-11-21 Thread Jochen Theodorou
and to add to the history... the bug was reported with an asm version before it started to produce nop, athrow. I think I remember also that this was not long before the change asm did. bye Jochen On 21.11.18 17:27, Remi Forax wrote: The history from the ASM point of view, starting with Java