Re: Upcoming RC release for 2.5.0

2018-03-19 Thread Paul King
I got caught up with conference activities and didn't finish all the bugs I wanted for RC1. Now that I'm back, I'll work on getting the RC1 release ready over the coming days. On Tue, Mar 6, 2018 at 9:41 PM, Paul King wrote: > > I am hoping to do the first RC release of 2.5.0 late this week or

Re: Java 8 Date/Time API Extensions Methods [GROOVY-8334]

2018-03-19 Thread Guillaume Laforge
+1! I've just read the documentation and it's clear and elegant. Great job! Really looking forward to seeing it integrated! It's a very nice and needed addition to the GDK :-) Guillaume On Sun, Mar 18, 2018 at 6:03 AM, Paul King wrote: > Looks good at first glance. Please go ahead with the PR

Re: Java 8 Date/Time API Extensions Methods [GROOVY-8334]

2018-03-19 Thread Daniel.Sun
Merged. https://github.com/apache/groovy/pull/674 Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: Java 8 Date/Time API Extensions Methods [GROOVY-8334]

2018-03-19 Thread Guillaume Laforge
Cool! On Mon, Mar 19, 2018 at 5:06 PM, Daniel.Sun wrote: > Merged. > https://github.com/apache/groovy/pull/674 > > Cheers, > Daniel.Sun > > > > -- > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html > -- Guillaume Laforge Apache Groovy committer & PMC Vice-President Devel

Re: Java 8 Date/Time API Extensions Methods [GROOVY-8334]

2018-03-19 Thread Joe Wolf
Thanks for the feedback and the pull! Glad there was consensus on the strict upper bound view for upto/downto. Everything was essentially straightforward one liners except for those two methods. Daniel, in regards to being considered as a champion candidate, that's flattering, but being able to co

Re: Java 8 Date/Time API Extensions Methods [GROOVY-8334]

2018-03-19 Thread Daniel Sun
Hi Joe, > Daniel, in regards to being considered as a champion candidate, that's > flattering, but being able to contribute to Groovy core is honor enough. You deserve it :-) > I've benefited from Groovy for years and I've long wanted to give back to > the community. So do I. Cheers, Daniel

Re: Java 8 Date/Time API Extensions Methods [GROOVY-8334]

2018-03-19 Thread Paul King
On Tue, Mar 20, 2018 at 2:19 AM, Joe Wolf wrote: > [...] Glad there was consensus on the strict upper bound view for > upto/downto. [...] > Being at the conference the last week, I didn't get time to look at that properly. It worries me that we'd have a different semantics for upto/downto compar