Re: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread Thibault Kruse
On Tue, Oct 4, 2016 at 1:22 AM, daniel_sun wrote: > 2) > subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/commands/DocCommand.groovy(TODO > confirm: https://github.com/danielsun1106/groovy-parser/issues/5); So the current Groovy parser could handle this case?

Re: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread Paul King
On Fri, Oct 7, 2016 at 8:16 PM, Thibault Kruse wrote: > On Tue, Oct 4, 2016 at 1:22 AM, daniel_sun wrote: >> 2) >> subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/commands/DocCommand.groovy(TODO >> confirm: https://github.com/danielsun1106/groovy-parser/issues/5); > >

Groovy macro documentation

2016-10-07 Thread Mario Garcia
Hi all: I sent a WIP with some groovy-macro documentation. The main problem with the PR is that there're two tests failing. I've been checking tests code and I can't see anything that may cause these tests to fail. I'll be reviewing the whole thing during the weekend but it would be better if any

Re: Groovy macro documentation

2016-10-07 Thread Sergei Egorov
Hey Mario, Wow! This is great! Didn't know you're working on it. I'll be happy to review :) Cheers, Sergei On Fri, Oct 7, 2016 at 1:53 PM Mario Garcia wrote: > Hi all: > > I sent a WIP with some groovy-macro documentation. The main problem with > the PR is that there're two tests failing. I'v

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread Jochen Theodorou
On 07.10.2016 08:52, daniel_sun wrote: How about providing a jar file containing the new parser, which is compiled by Java8. When developers use Java8, they can try the new parser by turning on the switch. I think for the time being we could make the new parser just a subproject that depends

Re: Groovy macro documentation

2016-10-07 Thread Guillaume Laforge
For reference, here's the PR: https://github.com/apache/groovy/pull/439 On Fri, Oct 7, 2016 at 1:00 PM, Sergei Egorov wrote: > Hey Mario, > > Wow! This is great! Didn't know you're working on it. I'll be happy to > review :) > > > Cheers, > Sergei > > On Fri, Oct 7, 2016 at 1:53 PM Mario Garcia

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread daniel_sun
I see. Feel free to merge the new parser back when you think it is mature and ready to go home ;) Currently The parser is lack of some syntax checks(e.g. continue should only be used in loop) and friendly messages for developers. Cheers, Daniel.Sun 在 "Jochen Theodorou [via Groovy]" ，2016年1

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread Jochen Theodorou
On 07.10.2016 13:35, daniel_sun wrote: I see. Feel free to merge the new parser back when you think it is mature and ready to go home ;) Currently The parser is lack of some syntax checks(e.g. continue should only be used in loop) and friendly messages for developers. Before that I would li

Re: Groovy macro documentation

2016-10-07 Thread Paul King
I'll try to review over the next little while too. Looks very promising at first glance! Exciting to see a good start! Paul. On Fri, Oct 7, 2016 at 9:17 PM, Guillaume Laforge wrote: > For reference, here's the PR: > https://github.com/apache/groovy/pull/439 > > On Fri, Oct 7, 2016 at 1:00 PM, Se

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread daniel_sun
OK. The 3 remaining failed test cases of last CI have been fixed on my local machine. It's pity that travis ci fails to run test cases recently. So I'm applying a new CI instance :) Cheers, Daniel.Sun 在 "Jochen Theodorou [via Groovy]" ，2016年10月7日 19:40写道： On 07.10.2016 13:35, daniel_sun

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread daniel_sun
Jochen, you can see the test result at: http://ci.groovy-lang.org/viewType.html?buildTypeId=Groovy_Antlr4grammar 在 "Jochen Theodorou [via Groovy]" ，2016年10月7日 下午7:40写道： On 07.10.2016 13:35, daniel_sun wrote: > I see. > > Feel free to merge the new parser back when you think it is mature and