Re: groovy git commit: GROOVY-7876: ClassCastException when calling DefaultTypeTransformation#compareEqual (closes #368)

2016-07-22 Thread Jochen Theodorou
On 22.07.2016 01:30, pa...@apache.org wrote: Repository: groovy Updated Branches: refs/heads/master 858a6fd2e -> 9159673d6 GROOVY-7876: ClassCastException when calling DefaultTypeTransformation#compareEqual (closes #368) [...] http://git-wip-us.apache.org/repos/asf/groovy/blob/9159673d

Re: groovy git commit: GROOVY-7876: ClassCastException when calling DefaultTypeTransformation#compareEqual (closes #368)

2016-07-22 Thread Paul King
Happy to change if there is indeed a problem but I still can't see an issue myself. Perhaps I need examples. More comments below. But I do agree the code could be made easier to read - the double negatives don't help. On Fri, Jul 22, 2016 at 8:29 PM, Jochen Theodorou wrote: > > > On 22.07.2016 0

Re: groovy git commit: GROOVY-7876: ClassCastException when calling DefaultTypeTransformation#compareEqual (closes #368)

2016-07-22 Thread Jochen Theodorou
On 22.07.2016 13:17, Paul King wrote: [...] Which part could throw a ClassCastException above? the compareTo itself. actually, let me think out loud here... We have two cases to consider, x==y (equalityCheckOnly==true) and x<=>y (equalityCheckOnly=false). In the first case we do not want a