Re: The order of modifiers and annotations

Thanks :) 在 "Marcin Erdmann [via Groovy]" ，2017年1月20日 下午5:09写道： Awesome! On Thu, Jan 19, 2017 at 11:01 AM, Daniel Sun <[hidden email]> wrote: I verified that the new parser Parrot does not have the issue( GROOVY-4757 ), the following test c

Re: The order of modifiers and annotations

Awesome! On Thu, Jan 19, 2017 at 11:01 AM, Daniel Sun wrote: > I verified that the new parser Parrot does not have the issue( GROOVY-4757 > ), the following test > case was added in the parrot branch. And I'll resolve the JIRA issue later. > >

Re: The order of modifiers and annotations

You're welcome :) -- View this message in context: http://groovy.329449.n5.nabble.com/The-order-of-modifiers-and-annotations-tp5737808p5737826.html Sent from the Groovy Dev mailing list archive at Nabble.com.

Re: The order of modifiers and annotations

Beautiful! thanks again Daniel. One more reason to get 3.0-ea out asap if you ask me ;-) On Thu, Jan 19, 2017 at 12:01 PM, Daniel Sun wrote: > I verified that the new parser Parrot does not have the issue( GROOVY-4757 > ), the following test >

Re: The order of modifiers and annotations

I verified that the new parser Parrot does not have the issue( GROOVY-4757 ), the following test case was added in the parrot branch. And I'll resolve the JIRA issue later. https://github.com/apache/groovy/commit/348465a1b193703c43aafeaabf2b2866

Re: The order of modifiers and annotations

I'll take a look at the issue later. Cheers, Daniel.Sun -- View this message in context: http://groovy.329449.n5.nabble.com/The-order-of-modifiers-and-annotations-tp5737808p5737818.html Sent from the Groovy Dev mailing list archive at Nabble.com.

Re: The order of modifiers and annotations

Yup, we've had this issue for a while https://issues.apache.org/jira/browse/GROOVY-4757 Would be great to fix it with the Parrot parser. On Thu, Jan 19, 2017 at 9:59 AM, Marcin Erdmann wrote: > Sorry for stealing the thread, but there is one annoying thing that > relates to parsing modifiers in

Re: The order of modifiers and annotations

Sorry for stealing the thread, but there is one annoying thing that relates to parsing modifiers in Groovy. Is there any chance to fix modifier being mandatory for methods with generic signatures in Parrot? I.e. this is now invalid: T foo(T bar) and has to be written like this to be parsed: pub

Re: The order of modifiers and annotations

> def is by now to be thought of as an alias for Object OK. I see. Thanks :) Cheers, Daniel.Sun -- View this message in context: http://groovy.329449.n5.nabble.com/The-order-of-modifiers-and-annotations-tp5737808p5737813.html Sent from the Groovy Dev mailing list archive at Nabble.com.

Re: The order of modifiers and annotations

On 19.01.2017 08:22, Daniel Sun wrote: Should we check the redundant modifiers? e.g. *Current* class A { private def a // def is redundant. IMHO, I really don't like it... } *Suggested* class A { private a } def is by now to be thought of as an alias for Object. In that sense it i

Re: The order of modifiers and annotations

On 19.01.2017 08:13, Daniel Sun wrote: Hi all, Currently the old parser allows mixing modifiers and annotations, e.g. *Current* @interface Test1 {} @interface Test2 {} @Test1 final @Test2 a *Suggested* @interface Test1 {} @interface Test2 {} @Test1 @Test2 final a this looks right to

Re: The order of modifiers and annotations

Should we check the redundant modifiers? e.g. *Current* class A { private def a // def is redundant. IMHO, I really don't like it... } *Suggested* class A { private a } Cheers, Daniel.Sun -- View this message in context: http://groovy.329449.n5.nabble.com/The-order-of-modifiers-and