Re: Groovy 2.5.4 planning

2018-11-06 Thread Milles, Eric (TR Tech, Content & Ops)
Paul, I have been working on a patch for debugger stepping issues described in GROOVY-4063, GROOVY-7647, GROOVY-7918 and GROOVY-8742. I am currently testing this patch to StatementWriter. Could you give this a quick try with the core project's tests? Can you see any problems with this approa

Re: Groovy 2.5.4 planning

2018-11-02 Thread Daniel Sun
Gotcha. The `GProperties` will be included in 3.0.0. Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: Groovy 2.5.4 planning

2018-11-02 Thread Guillaume Laforge
Agreed, we normally don't add new features in bug fix releases, but only in main releases. On Fri, Nov 2, 2018 at 10:07 AM Cédric Champeau wrote: > -1 to including GProperties in a bugfix release. There's apparently > discussion about the implication of doing this, and a bugfix release is not >

Re: Groovy 2.5.4 planning

2018-11-02 Thread Cédric Champeau
-1 to including GProperties in a bugfix release. There's apparently discussion about the implication of doing this, and a bugfix release is not meant to add new features. Le ven. 2 nov. 2018 à 00:46, Daniel.Sun a écrit : > Hi Paul, > > I wish GProperties could be included in 2.5.4. Here is

Re: Groovy 2.5.4 planning

2018-11-02 Thread Guillaume Laforge
I was also thinking of a Boolean in a constructor. Le ven. 2 nov. 2018 à 07:23, Paul King a écrit : > While I think security is very important to consider, I am unsure whether > the switch is the way to go. Such switches are global in nature and that > means you can't as easily as you might like

Re: Groovy 2.5.4 planning

2018-11-01 Thread Paul King
While I think security is very important to consider, I am unsure whether the switch is the way to go. Such switches are global in nature and that means you can't as easily as you might like use different GProperty instances in different contexts with different security contexts. Given use of GPro

Re: Groovy 2.5.4 planning

2018-11-01 Thread Daniel Sun
Hi Andres, > if GProperties is added to core I’d suggest to set that flag to false as default. Agreed :) > Additionally, couldn’t this behavior be added to ConfigSlurper? As you can see, `GProperties` is a subclass of `Properties`, I recommend groovy users to use the en

Re: Groovy 2.5.4 planning

2018-11-01 Thread Andres Almiray
Hi Daniel, Then so, if GProperties is added to core I’d suggest to set that flag to false as default. Additionally, couldn’t this behavior be added to ConfigSlurper? Cheers Andres Sent from my primitive tricorder > On Nov 1, 2018, at 10:49 PM, Daniel Sun wrote: > > Hi Andres, > > We

Re: Groovy 2.5.4 planning

2018-11-01 Thread Daniel Sun
Hi Andres, We can disable running code feature by default(enabled by a switch, e.g. -Dgroovy.properties.evaluate.code=true). Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: Groovy 2.5.4 planning

2018-11-01 Thread Andres Almiray
FWIW enabling arbitrary code on a properties file sounds like a risk to me. What if this be released as a standalone library for people to try it out first? Remember once added to Groovy core it’ll be hard to remove later. Best Andres Sent from my primitive tricorder > On Nov 1, 2018, at 7:4

Re: Groovy 2.5.4 planning

2018-11-01 Thread Daniel.Sun
Hi Paul, I wish GProperties could be included in 2.5.4. Here is the relevant PR: https://github.com/apache/groovy/pull/818 Cheers, Daniel.Sun - Daniel Sun Apache Groovy committer Blog: http://blog.sunlan.me Twitter: @daniel_sun -- Sent from: http://groovy.329449.n5.nabble.com/G