Hi Paul King,
Thank you very much for your time in doing the review.
I have implemented the suggested changes and pushed to the branch in my
fork.
All tests passed. Same PR Link below.
https://github.com/adithyank/groovy/pull/1
Kindly suggest the way forward...!
Thanks,
Adithyan K
India
On
My suggestions:
* alter your code style to match the existing style
* rename `after` to `takeAfter`
* rename `before` to `takeBefore`
* rename `between` to `takeBetween`
* no need for `stripLeft` since that is what `drop` does - with a minor
difference in behavior for the -1 case
* rename `stripRi
I have created a PR for this change and kept in my fork itself. Link below
https://github.com/adithyank/groovy/pull/1
I have a doubt whether a jira issue be created for every commit...
How should I Proceed...
Kindly advice
-
Thanks,
Adithyan K
India
--
Sent from: http://groovy.329449.n5
There are couple of queries and I responded inline. How should I proceed now?
Can I start coding ? or I have to write the documentation along with
implementation details some where and send the link?
Kindly advice
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
-the-groovy-platform-itself-for-more-script-like-use-cases-td5750522.html>
>
> >>
> >> post, I have created this topic for `More Default String Methods`
> >>
> >> I would like to work in these if the community accepts this proposal
> >>
> >&
ic for `More Default String Methods`
I would like to work in these if the community accepts this proposal
//Method to return left n characters
*1. static String left(String self, int chars)*
self[0..chars]?
Having a method here might be useful, but I would call it "fromLeft .
"left&qu
On 12.10.2018 21:22, adithyank wrote:
As suggested by Jochen Theodorou in this
link
<http://groovy.329449.n5.nabble.com/New-DSLs-in-the-groovy-platform-itself-for-more-script-like-use-cases-td5750522.html>
post, I have created this topic for `More Default String Methods`
I would like to w
As suggested by Jochen Theodorou in this
link
<http://groovy.329449.n5.nabble.com/New-DSLs-in-the-groovy-platform-itself-for-more-script-like-use-cases-td5750522.html>
post, I have created this topic for `More Default String Methods`
I would like to work in these if the community a
