I made a separate branch and a PR https://github.com/apache/groovy/pull/548
If you want you can commit with your user, most of the code is actually
yours.
--emi
On Wed, May 24, 2017 at 6:01 PM, John Wagenleitner <
john.wagenleit...@gmail.com> wrote:
> Hi Emilian,
>
> Nice work, I tried out th
Hi Emilian,
Nice work, I tried out the new prefs dialog on Linux and Windows and it
looks good to me. I don't have a Mac to test with, but it sounds like a
nice touch adding it into the Mac menu bar.
I would recommend putting the commit in a separate feature branch before
submitting a pull reque
See
https://github.com/emilianbold/groovy/commit/6d0e4fa95190580d49e225b47158c79c42fa68f6
I've started from your solution and made some changes:
* Console.groovy also needs to load maxOutputChars from the prefs
* ConsolePreferences.groovy fixes only this issue, without the log file.
The layout is
Hi Emilian,
On Sat, May 20, 2017 at 7:35 AM, Emilian Bold
wrote:
> You initial dialog is a good start, but what should it hold: all the pref
> keys from Console? Or just start with maxOutputChars?
>
>
I don't think it would be necessary to add all the options already
available to the dialog, so
You initial dialog is a good start, but what should it hold: all the pref
keys from Console? Or just start with maxOutputChars?
The log file UI should be added once #8180 is done.
I never touched GroovyConsole before, but it seems interesting. Reminds me
of ANTLRWorks which I just used the other
Hi Emilian,
I added a comment on that issue, I think it would also be handy to have a
new Preferences dialog for general settings such as this. Having a dialog
behind a new menu item such as Edit > Preferences could have an edit box
for inputting/displaying the output limit that is backed by a pre
Hello,
I would like to help out with the task listed at
https://helpwanted.apache.org/task.html?72ff9c55
Console.groovy maxOutputChars already has a System.property so I'm not
certain what's required for #GROOVY-3270, perhaps something like:
-int maxOutputChars =
System.getProperty('groovy.c
