Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-09 Thread daniel_sun
NO... I did not see them in the failing test list when using travis ci. It is lucky that Sergei had locate the cause of the failing tests and made a PR as follows: https://github.com/apache/groovy/pull/443 在 "Jochen Theodorou [via Groovy]" ,2016年10月9日 15:03写道: On 07.10.2016 18:09, daniel_su

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-09 Thread Jochen Theodorou
On 07.10.2016 18:09, daniel_sun wrote: Jochen, you can see the test result at: http://ci.groovy-lang.org/viewType.html?buildTypeId=Groovy_Antlr4grammar thanks... but there are 3 tests failing. Are those the test you have a local fix for? bye Jochen

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-08 Thread daniel_sun
IMO, when the new parser passes all test cases of groovy project, that says it conforms to GLS. All groovy program should conform to GLS, shouldn't them? :-) But we can modify GLS if Groovy core team approves ;-) 在 "Thibault Kruse [via Groovy]" ,2016年10月9日 13:55写道: Should the new parser al

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-08 Thread Thibault Kruse
Should the new parser also pass tests for the most-used frameworks before being merged? Grails, Gradle, Spock and Geb come to my mind. On Fri, Oct 7, 2016 at 8:40 PM, Jochen Theodorou wrote: > > > On 07.10.2016 13:35, daniel_sun wrote: >> >> I see. >> >> Feel free to merge the new parser back whe

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread daniel_sun
Jochen, you can see the test result at: http://ci.groovy-lang.org/viewType.html?buildTypeId=Groovy_Antlr4grammar 在 "Jochen Theodorou [via Groovy]" ,2016年10月7日 下午7:40写道: On 07.10.2016 13:35, daniel_sun wrote: > I see. > > Feel free to merge the new parser back when you think it is mature and

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread daniel_sun
OK. The 3 remaining failed test cases of last CI have been fixed on my local machine. It's pity that travis ci fails to run test cases recently. So I'm applying a new CI instance :) Cheers, Daniel.Sun 在 "Jochen Theodorou [via Groovy]" ,2016年10月7日 19:40写道: On 07.10.2016 13:35, daniel_sun

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread Jochen Theodorou
On 07.10.2016 13:35, daniel_sun wrote: I see. Feel free to merge the new parser back when you think it is mature and ready to go home ;) Currently The parser is lack of some syntax checks(e.g. continue should only be used in loop) and friendly messages for developers. Before that I would li

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread daniel_sun
I see. Feel free to merge the new parser back when you think it is mature and ready to go home ;) Currently The parser is lack of some syntax checks(e.g. continue should only be used in loop) and friendly messages for developers. Cheers, Daniel.Sun 在 "Jochen Theodorou [via Groovy]" ,2016年1

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-07 Thread Jochen Theodorou
On 07.10.2016 08:52, daniel_sun wrote: How about providing a jar file containing the new parser, which is compiled by Java8. When developers use Java8, they can try the new parser by turning on the switch. I think for the time being we could make the new parser just a subproject that depends

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-06 Thread daniel_sun
t;> >> PS: The new parser requires Java8 because streams and lambda expression >> are >> used. >> >> >> Cheers, >> Daniel.Sun >> >> >> 发件人: Graeme Rocher-2 [via Groovy] >> 发送时间: 2016年10月6日 18:27 >> 收件人: daniel_sun >> 主题: R

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-06 Thread Paul King
;> >> PS: The new parser requires Java8 because streams and lambda expression >> are >> used. >> >> >> Cheers, >> Daniel.Sun >> >> >> 发件人: Graeme Rocher-2 [via Groovy] >> 发送时间: 2016年10月6日 18:27 >> 收件人: da

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-06 Thread daniel_sun
t; > 发件人: Graeme Rocher-2 [via Groovy] > 发送时间: 2016年10月6日 18:27 > 收件人: daniel_sun > 主题: Re: 答复: [PROGRESS REPORT 20161004]groovy-parser > > Hi Daniel, > > Yes I have seen that before, it happens when Travis runs out of memory > since each Travis

Re: 答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-06 Thread Graeme Rocher
because streams and lambda expression are > used. > > > Cheers, > Daniel.Sun > > > 发件人: Graeme Rocher-2 [via Groovy] > 发送时间: 2016年10月6日 18:27 > 收件人: daniel_sun > 主题: Re: 答复: [PROGRESS REPORT 20161004]groovy-parser > > Hi Daniel, &g

答复: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-06 Thread daniel_sun
list archive at Nabble.com. > > > > -- > Graeme Rocher > > > > If you reply to this email, your message will be added to the discussion > below: > http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161004-groovy-parser-tp5735725p

Re: 答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-06 Thread Graeme Rocher
e Rocher > > > > If you reply to this email, your message will be added to the discussion > below: > http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161004-groovy-parser-tp5735725p5735829.html > To unsubscribe from [PROGRESS REPORT 201610

答复: [PROGRESS REPORT 20161004]groovy-parser

2016-10-06 Thread daniel_sun
Hi Graeme, The last test result is shown as following: https://travis-ci.org/danielsun1106/groovy/builds/165263810 13395 tests completed, 3 failed, 9 skipped Currently I'm trying to solve the following issue, which blocks me to verify issues. It's pity that I'm not very familiar