Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

2018-05-03 Thread Remko Popma
+1 On Thu, May 3, 2018 at 6:52 PM, John Wagenleitner < john.wagenleit...@gmail.com> wrote: > +1 (binding) > > On Thu, May 3, 2018 at 1:49 AM, Paul King wrote: > >> >> Dear development community, >> >> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release! >> >> This release include

Re: [VOTE] Support Java-like array

2018-05-03 Thread Daniel.Sun
Hi Paul, I've added your proposed provisos to the PR. Thanks for your voting. Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: [VOTE] Support Java-like array

2018-05-03 Thread Paul King
+1 with the following provisos: * we need to update the breaking changes section of 3.0.0 release notes on the website (site/src/site/releasenotes/groovy-3.0.adoc) to include the cases listed in GROOVY-8561 * we need to update the "Array initializers" section of core-differences-java.adoc (we need

[VOTE] Support Java-like array

2018-05-03 Thread Daniel.Sun
Dear development community, In order to improve Groovy's compatibility with Java(Copy & Paste) and make Groovy more friendly to Java developers[1], I propose to support Java-like array[2][3] and start the VOTE thread for supporting Java-like array. Please vote on supporting Java-like ar

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

2018-05-03 Thread John Wagenleitner
+1 (binding) On Thu, May 3, 2018 at 1:49 AM, Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release! > > This release includes 16 bug fixes/improvements as outlined in the > changelog: > https://issues.apache.org/jira/secure/Relea

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

2018-05-03 Thread Daniel Sun
Hi Cédric, `org.codehaus.groovy.runtime.memoize.MemoizeTest#testMemoizeConcurrently` should be fixed now. Here is the relevant commit: https://github.com/apache/groovy/commit/639264e7fe9ed44f0b81266a24748e09c6d0b921 Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Gro

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

2018-05-03 Thread Cédric Champeau
+1, even though some tests are not passing, see below, I think we should take a look at them gradle -b wrapper.gradle wrapper : ok ./gradlew clean dist: ok (https://scans.gradle.com/s/c7jwthugis7b2, we seriously need to do something for the performance of Groovydoc...) ./gradlew testAll: ko (https

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

2018-05-03 Thread Daniel Sun
+1 All tests pass, and I built groovy from source code and tested groovy console via the following code, which runs well. ``` class A { enum E { E1, E2 } } class B extends A { E e1() { E.E1 } E e2() { E.E2 } } def b = new B() assert A.E.E1 == b.e1() assert A.E.E2 == b.e2() ``` Here

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

2018-05-03 Thread Guillaume Laforge
+1 (binding) Ran all the tests successfully, and also did my usual smoke tests with the Groovy Console. All went perfectly fine. Guillaume On Thu, May 3, 2018 at 10:49 AM, Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release!

[VOTE] Release Apache Groovy 2.5.0-rc-2

2018-05-03 Thread Paul King
Dear development community, I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release! This release includes 16 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12343030 Tag: https://git1-us-west.apac