Re: 'grails-app' folder name

2025-04-18 Thread Søren Berg Glasius
Hi Gianluca, To me, grails-app is just a folder name like webapp, so I don't see the benefit of changing the folder-name, except for a few letters shorter. If others think the idea is good, I'm not opposed to it, I just don't see a big win. Den fre. 18. apr. 2025 kl. 11.01 skrev Gianluca Sartori

Re: 'grails-app' folder name

2025-04-18 Thread James Fredley
I have never thought much about the grails-app directory name and do not think it should change since it does a good job describing the contents. We should review our documentation around the directory structure, for a Grails application, to ensure it clearly details the structure and purpose fo

Apache Grails 7.0.x GitHub Project Kanban Board is Live

2025-04-18 Thread James Fredley
All open issues and PRs from the Grails 7 GitHub project have been added to the Apache Grails 7.0.x GitHub Project. Close/Done were not added. All: https://github.com/orgs/apache/projects/487/views/1 By Milestone: https://github.com/orgs/apache/projects/487/views/2?sliceBy%5Bvalue%5D=grails%3A

'grails-app' folder name

2025-04-18 Thread Gianluca Sartori
I've been thinking about this forever... We have the `grails-app` folder containing the conventions over configuration project structure that is a Grails standard, a different one from the `src` folder structure. The fact it contains `grails` in its name can be useful to immediately recognise the

Re: [DISCUSS] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread Gianluca Sartori
I just want to thank you for the great work 👍 Gianluca Sartori On Thu, 17 Apr 2025 at 14:48, James Fredley wrote: > James, > > Thank you for the extremely detailed outline of the benefits and reasons > for finishing the move to a mono repo for the Core Grails Projects, by > consolidating the r

Re: 'grails-app' folder name

2025-04-18 Thread Andrew Garcia
Hi Gianluca, For me I try to use /assets to imply and assert files that participate in the asset-pipeline and are compiled & handled in a particular way with its own build system entirely separate from Angular -Andrew On Fri, Apr 18, 2025 at 8:54 AM Gianluca Sartori wrote: > Hi Andrew, > > out

[VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread James Daugherty
Hi Everyone, As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo for the "grails-core" libraries by merging the final 2 repositories together: grails-geb & grails-data-mapping. The vote is open for the next 72 hours and passes if all binding votes are cast in favor. [] +1 pr

Re: [VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread James Fredley
+1 (binding) James Fredley On 2025/04/18 15:20:04 James Daugherty wrote: > Hi Everyone, > > As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo > for the "grails-core" libraries by merging the final 2 repositories > together: grails-geb & grails-data-mapping. > > The vote i

Re: [DISCUSS] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread James Daugherty
The initial response seems positive and given that this was originally suggested in the other thread, I'm going to go ahead and start a vote thread. Thanks everyone! On Fri, Apr 18, 2025 at 4:00 AM Gianluca Sartori wrote: > I just want to thank you for the great work 👍 > > Gianluca Sartori > >

[VOTE] Change Default Branch on https://github.com/apache/grails-wrapper to 7.0.x

2025-04-18 Thread James Fredley
Hi Everyone, With the change to Apache Grails maven coordinates, we are moving grails-wrapper to version 7.0.x to match the Grails version. ASF requires a vote to change the default branch. See: https://github.com/apache/grails-wrapper/pull/32 https://github.com/apache/grails-wrapper The vot

Re: 'grails-app' folder name

2025-04-18 Thread Andrew Garcia
Hi Gianluca, We hold out angular files in src/main/client which I’d say also makes it qualify as the “webapp”. For me the grails-app folder helps make clear the separation of concerns; grails-app is my backend benefiting from all the frameworks benefits and conventions, src is the Wild West of p

Re: 'grails-app' folder name

2025-04-18 Thread Gianluca Sartori
Hi Andrew, out of curiosity, what's the reason why you are not using the `/grails-app/assets` folder to store your client side JS code? Gianluca Sartori On Fri, 18 Apr 2025 at 14:44, Andrew Garcia wrote: > Hi Gianluca, > We hold out angular files in src/main/client which I’d say also makes it

Re: 'grails-app' folder name

2025-04-18 Thread Brandon Howard
I get what you’re going for and I appreciate you throwing the idea out there. But I don’t think this is the right move. The grails app folder isn’t just a label. It’s part of how the framework functions. Grails, the build system, plugins, and pretty much every tool in the ecosystem expect that

Re: [VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread Andrew Garcia
+1 (non-binding) On Fri, Apr 18, 2025 at 11:22 AM James Daugherty wrote: > Hi Everyone, > > As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo > for the "grails-core" libraries by merging the final 2 repositories > together: grails-geb & grails-data-mapping. > > The vote is

[VOTE] Change Default Branch on https://github.com/apache/grails-profiles to 7.0.x

2025-04-18 Thread James Fredley
Hi Everyone, With the change to Apache Grails maven coordinates, we are moving profiles back to version 7.0.x to match the Grails version. ASF requires a vote to change the default branch. We were on Version 10.0.x due to the angular profile being a higher version when the profile project was

Re: [VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread Gianluca Sartori
+1 Gianluca Sartori On Fri, 18 Apr 2025 at 17:20, James Daugherty wrote: > Hi Everyone, > > As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo > for the "grails-core" libraries by merging the final 2 repositories > together: grails-geb & grails-data-mapping. > > The vote

Re: [VOTE] Change Default Branch on https://github.com/apache/grails-wrapper to 7.0.x

2025-04-18 Thread James Daugherty
+1 (binding) On Fri, Apr 18, 2025 at 6:19 PM James Fredley wrote: > Hi Everyone, > > With the change to Apache Grails maven coordinates, we are moving > grails-wrapper to version 7.0.x to match the Grails version. ASF requires a > vote to change the default branch. > > See: https://github.com/ap

Re: [VOTE] Change Default Branch on https://github.com/apache/grails-profiles to 7.0.x

2025-04-18 Thread James Daugherty
+1 (binding) On Fri, Apr 18, 2025 at 5:34 PM James Fredley wrote: > Hi Everyone, > > With the change to Apache Grails maven coordinates, we are moving profiles > back to version 7.0.x to match the Grails version. ASF requires a vote to > change the default branch. We were on Version 10.0.x due

Re: [VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread David Estes
+1 (binding) > On Apr 18, 2025, at 1:15 PM, Gianluca Sartori wrote: > > +1 > > Gianluca Sartori > > > On Fri, 18 Apr 2025 at 17:20, James Daugherty > wrote: > >> Hi Everyone, >> >> As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo >> for the "grails-core" libraries b

Re: 'grails-app' folder name

2025-04-18 Thread James Daugherty
The grails-app directory is there to force a division between domain | views | services | assets. It can contain non-source files, and thus it wouldn't make sense to have it under src ever. We need a way to distinguish this, and putting it under resource wouldn't make sense since the files are of

Re: [VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread Brian Koehmstedt
+1 (binding) On 2025/04/18 15:20:04 James Daugherty wrote: > Hi Everyone, > > As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo > for the "grails-core" libraries by merging the final 2 repositories > together: grails-geb & grails-data-mapping. > > The vote is open for the

Re: [VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread James Fredley
+1 (binding) James Fredley On 2025/04/18 15:20:04 James Daugherty wrote: > Hi Everyone, > > As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo > for the "grails-core" libraries by merging the final 2 repositories > together: grails-geb & grails-data-mapping. > > The vote i

Re: [VOTE] Merge Grails-geb & Grails-data-mapping to form a mono repo

2025-04-18 Thread Mattias Reichel
+1 (binding) / Mattias Den fre 18 apr. 2025 17:25James Fredley skrev: > +1 (binding) > > James Fredley > > On 2025/04/18 15:20:04 James Daugherty wrote: > > Hi Everyone, > > > > As per the [DISCUSS] thread [1], I'd like to propose we form a mono repo > > for the "grails-core" libraries by mergi